[PRE REVIEW]: EPyT-C: A Python package for water quality modeling in water distribution systems

[editorialbot]

Submitting author: @SWIL-IITK (Abhijith G R)
Repository: https://github.com/SWIL-IITK/EPyT-C
Branch with paper.md (empty if default branch):
Version: version 1
Editor: Pending
Reviewers: Pending
Managing EiC: Kristen Thyng

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/686dfebf53cb08d68b186b6ef34a457d"><img src="https://joss.theoj.org/papers/686dfebf53cb08d68b186b6ef34a457d/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/686dfebf53cb08d68b186b6ef34a457d/status.svg)](https://joss.theoj.org/papers/686dfebf53cb08d68b186b6ef34a457d)

Author instructions

Thanks for submitting your paper to JOSS @SWIL-IITK. Currently, there isn't a JOSS editor assigned to your paper.

@SWIL-IITK if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands

[editorialbot]

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

[editorialbot]

Software report:

github.com/AlDanial/cloc v 1.88  T=0.06 s (628.4 files/s, 78707.6 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          28            397            819           2860
Markdown                         5            124              0            316
TOML                             2             31             31            155
TeX                              1              7              0             69
YAML                             2              7              4             53
reStructuredText                 1              3              0              9
-------------------------------------------------------------------------------
SUM:                            39            569            854           3462
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

[editorialbot]

Wordcount for paper.md is 2258

[editorialbot]

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- None

MISSING DOIs

- None

INVALID DOIs

- https://doi.org/10.1061/(ASCE)EE.1943-7870.0001918 is INVALID because of 'https://doi.org/' prefix
- https://doi.org/10.3390/w14101665 is INVALID because of 'https://doi.org/' prefix
- https://doi.org/10.1016/j.jenvman.2022.115817 is INVALID because of 'https://doi.org/' prefix
- https://doi.org/10.1061/(ASCE)0733-9496(2002)128:5(334) is INVALID because of 'https://doi.org/' prefix

[kthyng]

Hi @SWIL-IITK — was this paper submitted previously? If so can you link to the github pre-review issue?

[editorialbot]

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

[editorialbot]

Five most similar historical JOSS papers:

TESPy: Thermal Engineering Systems in Python
Submitting author: @fwitte
Handling editor: @kyleniemeyer (Active)
Reviewers: @arosen93, @corentin-dev
Similarity score: 0.8568

PySWMM: The Python Interface to Stormwater Management Model (SWMM)
Submitting author: @katmratliff
Handling editor: @kbarnhart (Retired)
Reviewers: @nickrsan, @jrkasprzyk
Similarity score: 0.8432

Water Systems Integrated Modelling framework, WSIMOD: A Python package for integrated modelling of water quality and quantity across the water cycle
Submitting author: @barneydobson
Handling editor: @crvernon (Active)
Reviewers: @cheginit, @jlarsen-usgs
Similarity score: 0.8427

epyc: Computational experiment management in Python
Submitting author: @simoninirelland
Handling editor: @ajstewartlang (Active)
Reviewers: @zbeekman, @lorenzo-rovigatti, @amritagos
Similarity score: 0.8321

rtdpy: A python package for residence time distributions
Submitting author: @MatthewFlamm
Handling editor: @xuanxu (Active)
Reviewers: @ctdegroot, @dandavies99
Similarity score: 0.8319

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

[SWIL-IITK]

Hi @SWIL-IITK — was this paper submitted previously? If so can you link to the github pre-review issue?

Hi @kthyng Please find the link: #5650

[SWIL-IITK]

Hi @kthyng @editorialbot , below is the list of potential reviewers:

1. Demetrios G. Eliades (eldemet)
2. larnsce
3. abhiramm7

[kthyng]

Hi again @SWIL-IITK and thanks for your submission! I see it has changed a lot since you last submitted. We have a backlog of submissions so I will add this to our waitlist. Thanks for your patience.

In the meantime there are a few updates I request of your submission. If you can get them done relatively soon then let's just wait in the backlog, otherwise I can go ahead and pause your submission while you work on them:

• need more formal docs, preferably hosted on readthedocs or otherwise visible to users. I see you have examples — usually these would be notebooks or markdown that can be compiled so people can read them in a more user-friendly way.
• need tests to verify code performance
• your paper figures aren't coming through
• ccheck those DOI errors above (they aren't always correct but often are)
• You'll probably need to ultimately put your package on PyPI so you may want to do that now (or conda-forge)

[SWIL-IITK]

hi @g-jaykrishnan can you please see this?

[kthyng]

@SWIL-IITK How much time would you like to work through these changes? If, say, 1 week, I would suggest pausing this submission. If more than that I would suggest withdrawing and resubmitting.

[kthyng]

@SWIL-IITK Checking in again about this — I would suggest you withdraw and resubmit to get these packaging issues sorted before review. If I don't hear back by next Monday I'll go ahead and reject this assuming you'll do this.

[SWIL-IITK]

@kthyng Sorry for not getting back to you earlier. Thank you for the update. We are withdrawing the submission. Will work on it and resubmit.

[SWIL-IITK]

@kthyng Can you please help us with withdrawing the submission?

[kthyng]

Ok sure. I'll see if I can run the withdraw command.

[kthyng]

@editorialbot withdraw

[editorialbot]

Paper withdrawn.

[SWIL-IITK]

Ok sure. I'll see if I can run the withdraw command.

Thank you @kthyng

[SWIL-IITK]

@kthyng We have uploaded the latest version. Kindly check and do the needful.

Thanks