Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: A Module for Calibrating Impact Functions in the Climate Risk Modeling Platform CLIMADA #6719

Closed
editorialbot opened this issue May 3, 2024 · 26 comments
Assignees
Labels
pre-review Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented May 3, 2024

Submitting author: @peanutfun (Lukas Riedel)
Repository: https://github.com/CLIMADA-project/climada_python
Branch with paper.md (empty if default branch): calibrate-impact-functions
Version: v5
Editor: @observingClouds
Reviewers: @sunt05, @naingeet
Managing EiC: Chris Vernon

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/50845e31c6cb6894baae492bfd853671"><img src="https://joss.theoj.org/papers/50845e31c6cb6894baae492bfd853671/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/50845e31c6cb6894baae492bfd853671/status.svg)](https://joss.theoj.org/papers/50845e31c6cb6894baae492bfd853671)

Author instructions

Thanks for submitting your paper to JOSS @peanutfun. Currently, there isn't a JOSS editor assigned to your paper.

@peanutfun if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning labels May 3, 2024
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.5194/gmd-12-3085-2019 is OK
- 10.5194/gmd-14-351-2021 is OK
- 10.1038/s41592-019-0686-2 is OK
- 10.1016/j.firesaf.2015.04.008 is OK
- 10.5194/gmd-2021-192 is OK
- 10.5281/zenodo.8383171 is OK
- 10.5194/egusphere-2024-93 is OK
- 10.21203/rs.3.rs-3682198/v1 is OK
- 10.1002/met.2035 is OK
- 10.5194/nhess-21-279-2021 is OK
- 10.5194/nhess-2023-158 is OK
- 10.21203/rs.3.rs-3807553/v1 is OK
- 10.1175/2009BAMS2755.1 is OK
- 10.1175/2008MWR2395.1 is OK

MISSING DOIs

- No DOI given, and none found for title: Bayesian Optimization: Open source constrained glo...
- No DOI given, and none found for title: 2022 Disasters in Numbers
- No DOI given, and none found for title: Emergency Events Database (EM-DAT)
- No DOI given, and none found for title: Risk and Uncertainty Assessment for Natural Hazard...
- 10.1017/cbo9781107415379.016 may be a valid DOI for title: Human Health: Impacts, Adaptation, and Co-Benefits
- No DOI given, and none found for title: Oasis Loss Modelling Framework

INVALID DOIs

- https://doi.org/10.5194/nhess-21-393-2021 is INVALID because of 'https://doi.org/' prefix
- https://doi.org/10.5194/essd-12-817-2020 is INVALID because of 'https://doi.org/' prefix

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=0.45 s (514.4 files/s, 235062.3 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                         137           8499          18766          32640
CSV                             14              2              0           3462
Jupyter Notebook                38              0          36741           3082
Markdown                        10            248              0            737
reStructuredText                20            418            411            523
CSS                              1             91             11            405
TeX                              2             28              0            365
YAML                             6             26             26            207
make                             2             29              7            108
Bourne Shell                     3             20              1             44
Dockerfile                       1              7              8             15
-------------------------------------------------------------------------------
SUM:                           234           9368          55971          41588
-------------------------------------------------------------------------------

Commit count by author:

  1008	gabriela
   394	sameberenz
   342	emanuel-schmid
   283	Thomas Vogt
   186	Carmen Steinmann
   167	schmide
   107	Lukas Riedel
    94	Jan Hartman
    93	ThomasRoosli
    81	Evelyn-M
    73	ingajsa
    69	Chahan Kropf
    63	samluethi
    57	Emanuel Schmid
    56	Gabriela Aznar
    51	Yue Yu
    48	Benoît Guillod
    42	zeliest
    40	David N. Bresch
    40	frqqyy
    32	Chahan M. Kropf
    29	Samuel Lüthi
    29	aleciu
    29	gabrielaznar
    27	Chris Fairless
    23	timschmi95
    19	Marine Perus
    18	Samuel Eberenz
    17	Sam Luethi
    16	carmensteinmann
    15	manniepmkam
    14	Nicolas Colombi
    14	Simona Meiler
    13	wjan262
    10	climada
     9	Unknown
     9	aleeciu
     8	Thomas Röösli
     8	Zélie Stalhandske
     7	Carmen B. Steinmann
     6	Samuel Juhel
     6	leonie-villiger
     5	Alessio Ciullo
     5	NicolasColombi
     4	KasparTo
     4	Pui Man (Mannie) Kam
     4	Rachel_B
     4	Tobias Geiger
     4	climada.ethz.ch
     3	Evelyn Mühlhofer
     3	davidnbresch
     2	Benoit P. Guillod
     2	Sarah Hülsen
     2	Timo Schmid
     2	Zelie Stalhandske
     2	raphael-portmann
     2	veronicabozzini
     1	DarioStocker
     1	Kam Lam Yeung
     1	Mannie Kam
     1	Rachel Bungerer
     1	Schmid  Timo
     1	luseverin
     1	scem
     1	simonameiler

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 1089

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

🟡 License found: GNU General Public License v3.0 (Check here for OSI approval)

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@peanutfun
Copy link

@editorialbot commands

@editorialbot
Copy link
Collaborator Author

Hello @peanutfun, here are the things you can ask me to do:


# List all available commands
@editorialbot commands

# Get a list of all editors's GitHub handles
@editorialbot list editors

# Adds a checklist for the reviewer using this command
@editorialbot generate my checklist

# Set a value for branch
@editorialbot set joss-paper as branch

# Run checks and provide information on the repository and the paper file
@editorialbot check repository

# Check the references of the paper for missing DOIs
@editorialbot check references

# Generates the pdf paper
@editorialbot generate pdf

# Generates a LaTeX preprint file
@editorialbot generate preprint

# Get a link to the complete list of reviewers
@editorialbot list reviewers

@peanutfun
Copy link

peanutfun commented May 3, 2024

I suggest the following reviewers:

@peanutfun
Copy link

@editorialbot check references

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.5194/gmd-12-3085-2019 is OK
- 10.5194/gmd-14-351-2021 is OK
- 10.1038/s41592-019-0686-2 is OK
- 10.5194/nhess-21-393-2021 is OK
- 10.1016/j.firesaf.2015.04.008 is OK
- 10.5194/gmd-2021-192 is OK
- 10.5281/zenodo.8383171 is OK
- 10.5194/egusphere-2024-93 is OK
- 10.21203/rs.3.rs-3682198/v1 is OK
- 10.1002/met.2035 is OK
- 10.5194/nhess-21-279-2021 is OK
- 10.5194/nhess-2023-158 is OK
- 10.1017/CBO9781107415379.016 is OK
- 10.21203/rs.3.rs-3807553/v1 is OK
- 10.1175/2009BAMS2755.1 is OK
- 10.1175/2008MWR2395.1 is OK
- 10.5194/essd-12-817-2020 is OK

MISSING DOIs

- No DOI given, and none found for title: Bayesian Optimization: Open source constrained glo...
- No DOI given, and none found for title: 2022 Disasters in Numbers
- No DOI given, and none found for title: Emergency Events Database (EM-DAT)
- No DOI given, and none found for title: Risk and Uncertainty Assessment for Natural Hazard...
- No DOI given, and none found for title: Oasis Loss Modelling Framework

INVALID DOIs

- None

@peanutfun
Copy link

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@crvernon
Copy link

crvernon commented May 3, 2024

👋 @peanutfun - thanks for your submission to JOSS. We are currently managing a large backlog of submissions and the editor most appropriate for your area is already rather busy.

For now, we will need to waitlist this paper and process it as the queue reduces. Thanks for your patience!

@crvernon crvernon added the waitlisted Submissions in the JOSS backlog due to reduced service mode. label May 3, 2024
@crvernon
Copy link

crvernon commented May 3, 2024

@peanutfun since the majority of this codebase has been reviewed in other publications, will you post a list here showing where the newer code is within the original codebase? Thanks!

@peanutfun
Copy link

@crvernon Thanks for letting me know. We will be patient :)

The newer code is located in the /climada/util/calibrate/ directory in the calibrate-impact-funcions branch. All additions we submit via this publication, including the paper, a tutorial Jupyter script, and the documentation can be reviewed from the following pull request: CLIMADA-project/climada_python#692

@crvernon
Copy link

crvernon commented May 4, 2024

@editorialbot invite @observingClouds as editor

Hello @observingClouds are you able to take this one on as editor right now? It seems like a good fit for your skillset.

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@observingClouds
Copy link

@editorialbot assign me as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @observingClouds is now the editor

@crvernon crvernon removed the waitlisted Submissions in the JOSS backlog due to reduced service mode. label May 6, 2024
@observingClouds
Copy link

@editorialbot add @sunt05 as reviewer

@editorialbot
Copy link
Collaborator Author

@sunt05 added to the reviewers list!

@observingClouds
Copy link

@editorialbot add @naingeet as reviewer

@editorialbot
Copy link
Collaborator Author

@naingeet added to the reviewers list!

@observingClouds
Copy link

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #6755.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pre-review Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning
Projects
None yet
Development

No branches or pull requests

4 participants