Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PRE REVIEW]: popclass: a python package for classifying microlensing events #7342

Open
editorialbot opened this issue Oct 10, 2024 · 20 comments
Open

[PRE REVIEW]: popclass: a python package for classifying microlensing events #7342

editorialbot opened this issue Oct 10, 2024 · 20 comments
Labels
Dockerfile pre-review Python TeX Track: 1 (AASS) Astronomy, Astrophysics, and Space Sciences waitlisted Submissions in the JOSS backlog due to reduced service mode.

Comments

@editorialbot
Copy link
Collaborator

Submitting author: @astrophpeter (Peter McGill)
Repository: https://github.com/LLNL/popclass
Branch with paper.md (empty if default branch):
Version: v0.2.0
Editor: Pending
Reviewers: Pending
Managing EiC: Warrick Ball

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/0a324c62d0151b3f3bbace190597e7ac"><img src="https://joss.theoj.org/papers/0a324c62d0151b3f3bbace190597e7ac/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/0a324c62d0151b3f3bbace190597e7ac/status.svg)](https://joss.theoj.org/papers/0a324c62d0151b3f3bbace190597e7ac)

Author instructions

Thanks for submitting your paper to JOSS @astrophpeter. Currently, there isn't a JOSS editor assigned to your paper.

@astrophpeter if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 1 (AASS) Astronomy, Astrophysics, and Space Sciences labels Oct 10, 2024
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=0.07 s (606.2 files/s, 341788.7 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
CSV                              1              0              0          20001
Python                          11            446            590           1363
TeX                              2             28              0            472
reStructuredText                12            220            258            383
YAML                             8             26             51            193
Markdown                         3             40              0            155
Jupyter Notebook                 4              0            880            151
TOML                             1              5              0             32
DOS Batch                        1              8              1             26
Dockerfile                       1              4              0             20
make                             1              4              7              9
-------------------------------------------------------------------------------
SUM:                            45            781           1787          22805
-------------------------------------------------------------------------------

Commit count by author:

   186	Peter McGill
    64	gsallabe
    57	pre-commit-ci[bot]
    43	Zofia Kaczmarek
    23	Scott Perkins
    13	Peter Mcgill
    11	caitlinbegbie
     4	kaczmarek4
     1	zofiakaczmarek

@editorialbot
Copy link
Collaborator Author 

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.3847/1538-4357/ad3243 is OK
- 10.1109/MCSE.2007.55 is OK
- 10.1038/s41586-020-2649-2 is OK
- 10.3847/1538-3881/ac9518 is OK
- 10.3847/1538-4365/aafb69 is OK
- 10.48550/arXiv.2309.15310 is OK
- 10.3847/1538-4357/ad09bf is OK
- 10.1088/0004-637X/725/2/2166 is OK
- 10.3847/1538-4357/ab5fd3 is OK
- 10.3847/0004-637X/821/1/38 is OK
- 10.1016/j.ascom.2015.06.004 is OK
- 10.3847/1538-4357/ab042c is OK
- 10.48550/arXiv.1503.03757 is OK
- 10.1038/s41592-019-0686-2 is OK
- 10.1093/mnras/staa278 is OK
- 10.48550/arXiv.2403.09006 is OK
- 10.3847/1538-3881/ad4862 is OK
- 10.3847/1538-4357/ac739e is OK
- 10.3847/2041-8213/ac7442 is OK
- 10.21105/joss.01143 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: API design for machine learning software: experien...
- No DOI given, and none found for title: On Finding Black Holes in Photometric Microlensing...
- No DOI given, and none found for title: PyMultiNest: Python interface for MultiNest

❌ MISSING DOIs

- None

❌ INVALID DOIs

- https://doi.org/10.1016/j.ascom.2015.06.004 is INVALID because of 'https://doi.org/' prefix

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 1249

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

✅ License found: MIT License (Valid open source OSI approved license)

@editorialbot
Copy link
Collaborator Author

⚠️ An error happened when generating the pdf. Problem with ORCID (0000-0000-0000-0000) for Caitlin Begbie. Invalid ORCID.

@warrickball
Copy link

@astrophpeter — Thanks for your submission! All the suitable JOSS editors are currently working at capacity so I'm going to "waitlist" this review until an editor with the relevant expertise is available to take it on. Thanks for your patience!

In the meantime, if you could try to fix the errors in the paper. If Caitlin Begbie doesn't have an ORCID, you can just remove that line from their metadata.

As indicated, the DOI error looks like it's because the full URL (including https://doi.org/) has been given for Greenfield et al. (2015). You should replace this with just the DOI.

Finally, note that your paper is a bit long for JOSS. As mentioned in the docs,

The paper should be between 250-1000 words. Authors submitting papers significantly longer than 1000 words may be asked to reduce the length of their paper.

If you could squeeze it back under 1000 words, that'd be great.

@astrophpeter
Copy link

Thanks, Warrick. I will attempt to fix those issues shortly.

@astrophpeter
Copy link

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

SkyPy: A package for modelling the Universe
Submitting author: @rrjbca
Handling editor: @arfon (Active)
Reviewers: @cescalara, @rmorgan10
Similarity score: 0.7559

FIGARO: hierarchical non-parametric inference for population studies
Submitting author: @sterinaldi
Handling editor: @dfm (Active)
Reviewers: @dgerosa, @Uddiptaatwork
Similarity score: 0.7479

Astronomical échelle spectroscopy data analysis with muler
Submitting author: @gully
Handling editor: @xuanxu (Active)
Reviewers: @bmorris3, @wtgee
Similarity score: 0.7452

X-PSI: A Python package for neutron star X-ray pulse simulation and inference
Submitting author: @drannawatts
Handling editor: @adonath (Active)
Reviewers: @JohannesBuchner, @matteobachetti
Similarity score: 0.7419

pysersic: A Python package for determining galaxy structural properties via Bayesian inference, accelerated with jax
Submitting author: @prappleizer
Handling editor: @eloisabentivegna (Retired)
Reviewers: @AstroBarker, @JBorrow
Similarity score: 0.7412

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@astrophpeter
Copy link

@editorialbot commands

@editorialbot
Copy link
Collaborator Author

Hello @astrophpeter, here are the things you can ask me to do:


# List all available commands
@editorialbot commands

# Get a list of all editors's GitHub handles
@editorialbot list editors

# Adds a checklist for the reviewer using this command
@editorialbot generate my checklist

# Set a value for branch
@editorialbot set joss-paper as branch

# Run checks and provide information on the repository and the paper file
@editorialbot check repository

# Check the references of the paper for missing DOIs
@editorialbot check references

# Generates the pdf paper
@editorialbot generate pdf

# Generates a LaTeX preprint file
@editorialbot generate preprint

# Get a link to the complete list of reviewers
@editorialbot list reviewers

@astrophpeter
Copy link

@editorialbot check references

@astrophpeter
Copy link

@editorialbot check repository

@editorialbot
Copy link
Collaborator Author 

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.3847/1538-4357/ad3243 is OK
- 10.1109/MCSE.2007.55 is OK
- 10.1016/j.ascom.2015.06.004 is OK
- 10.1038/s41586-020-2649-2 is OK
- 10.3847/1538-3881/ac9518 is OK
- 10.3847/1538-4365/aafb69 is OK
- 10.48550/arXiv.2309.15310 is OK
- 10.3847/1538-4357/ad09bf is OK
- 10.1088/0004-637X/725/2/2166 is OK
- 10.3847/1538-4357/ab5fd3 is OK
- 10.3847/0004-637X/821/1/38 is OK
- 10.1016/j.ascom.2015.06.004 is OK
- 10.3847/1538-4357/ab042c is OK
- 10.48550/arXiv.1503.03757 is OK
- 10.1038/s41592-019-0686-2 is OK
- 10.1093/mnras/staa278 is OK
- 10.48550/arXiv.2403.09006 is OK
- 10.3847/1538-3881/ad4862 is OK
- 10.3847/1538-4357/ac739e is OK
- 10.3847/2041-8213/ac7442 is OK
- 10.21105/joss.01143 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: API design for machine learning software: experien...
- No DOI given, and none found for title: On Finding Black Holes in Photometric Microlensing...
- No DOI given, and none found for title: PyMultiNest: Python interface for MultiNest

❌ MISSING DOIs

- None

❌ INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=0.07 s (632.9 files/s, 356566.5 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
CSV                              1              0              0          20001
Python                          11            446            590           1363
TeX                              2             28              0            472
reStructuredText                12            220            258            383
YAML                             8             26             51            193
Jupyter Notebook                 4              0            880            151
Markdown                         3             37              0            139
TOML                             1              5              0             32
DOS Batch                        1              8              1             26
Dockerfile                       1              4              0             20
make                             1              4              7              9
-------------------------------------------------------------------------------
SUM:                            45            778           1787          22789
-------------------------------------------------------------------------------

Commit count by author:

   190	Peter McGill
    64	gsallabe
    58	pre-commit-ci[bot]
    43	Zofia Kaczmarek
    23	Scott Perkins
    13	Peter Mcgill
    11	caitlinbegbie
     4	kaczmarek4
     1	zofiakaczmarek

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 989

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

✅ License found: MIT License (Valid open source OSI approved license)

@astrophpeter
Copy link

Ok, I think everything is fixed now @warrickball . Thanks for your help.

@warrickball warrickball added the waitlisted Submissions in the JOSS backlog due to reduced service mode. label Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Dockerfile pre-review Python TeX Track: 1 (AASS) Astronomy, Astrophysics, and Space Sciences waitlisted Submissions in the JOSS backlog due to reduced service mode.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@astrophpeter @warrickball @editorialbot