Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix feature manager #203

Merged
merged 1 commit into from
Jun 29, 2021
Merged

Fix feature manager #203

merged 1 commit into from
Jun 29, 2021

Conversation

danixeee
Copy link
Contributor

Description (e.g. "Related to ...", etc.)

Fix adding help attributes to registered feature/command handlers.

This fix makes sure that this piece of code is properly executed and handler's return values are type-checked.

Code review checklist (for code reviewer to complete)

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Commit messages are meaningful (see this for details)
  • Tests have been included and/or updated, as appropriate
  • Docstrings have been included and/or updated, as appropriate
  • Standalone docs have been updated accordingly
  • CONTRIBUTORS.md was updated, as appropriate
  • Changelog has been updated, as needed (see CHANGELOG.md)

@danixeee danixeee added the bug Something isn't working label Jun 28, 2021
@danixeee danixeee requested a review from renatav June 28, 2021 13:34
@danixeee danixeee force-pushed the danixeee/fix-feature-mngr branch from 8cc1f0e to b29ee95 Compare June 28, 2021 13:38
@renatav renatav merged commit 723f467 into master Jun 29, 2021
@renatav renatav deleted the danixeee/fix-feature-mngr branch June 29, 2021 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants