-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PDF and XML files imported as figure files #36
Comments
This has now been effectively deprecated: Lines 535 to 537 in a7451e3
The importer now only allows PDFs: Lines 400 to 407 in a7451e3
|
The use case for importing a manuscript file would be: a journal has articles in progress during migration. But this would likely not happen with more than 10 or so articles, so the benefit of writing an importer would not be felt, since that many can be done manually in not too much time. So, what if we rethink this feature as a more generic file importer, where you can control what types of files are being imported--not just MS files but all kinds of files in Janeway. |
PDF and XML files are not recognized on import as editable files and so are imported as figure_data_files:
imports/utils.py
Line 302 in e54b59a
imports/utils.py
Lines 357 to 360 in e54b59a
Seemingly as a result, they do not appear in the typesetting plugin in the place that they can be converted to galley files easily:
https://github.com/BirkbeckCTP/typesetting/blob/48720ad13775a640d5349e2f652288526f693422/templates/typesetting/elements/production_files.html#L20
As a quick fix, we can class these as manuscript files on import.
The text was updated successfully, but these errors were encountered: