Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import fails if a row has an invalid datetime value #69

Open
mauromsl opened this issue Jul 27, 2022 · 1 comment
Open

Import fails if a row has an invalid datetime value #69

mauromsl opened this issue Jul 27, 2022 · 1 comment
Labels
bug Something isn't working dev ready M

Comments

@mauromsl
Copy link
Member

When using the import/export/update system offered in this plugin, if a CSV file contains a corrupt datetime string, an exception is raised ending the import process abruptly, which can leave the imported data in an incosistent state.

During the preprocessing of the file, we should verify the integrity of all datetime strings before allowing the user to execute the import.

Or implement #2

@joemull joemull added the bug Something isn't working label Mar 13, 2024
@ajrbyers
Copy link
Member

A stopgap solution would be to wrap each article in a transaction that we can rollback when an article import fails. We can then store import errors for each article and report this to the user for them to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dev ready M
Projects
None yet
Development

No branches or pull requests

3 participants