-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the author submission screen #4519
Comments
@MartinPaulEve @joemull @mauromsl @StephDriver @S-Haime @Astronaut-resting here is the sketch I put together for the making the author interface a single column. I feel like this is much easier to scan and understand than the current layout. For CREDIT: Clicking the "Add CREDIT" button will give a modal where the user can select which to add. Alternatively it could be a button that presents a dropdown of options. Removing could be handled by add an [x] button to each. For ROR: Option to manage ROR could be a formset triggered by clicking edit, either as a modal or seperate page. |
I think something else is needed here to make this compatible with WCAG 2.4.4 link purpose in context. see also ROR Docs | Display |
Ah nice to see they have this. Ive uploaded a slightly tweaked version. It removes stuff about dragging and dropping which we don't really want. |
@StephDriver this is great! As discussed on Discord lets use our time on Thursday to iterate this a bit. |
I really like the direction this is heading in. It's a good candidate for the design meeting tomorrow. The only suggestion I have is to use single-click buttons to change the correspondence author, like the move up and move down buttons. All non-primary authors could have a button called "Make correspondence author", and the correspondence author could have a label instead of a button that says "Correspondence author", perhaps with an appropriate icon like a star. |
I'm saying no, mostly because I think this contradicts point 3 below about making it really really really clear and intuitive that there is only one correspondence author. But I do think this is a debatable point! To me, having the button on every author card makes sense if you can have multiple 'main' authors. But if you can only have one, then it is important for the user to have to acknowledge (on a subconscious level) that they are removing one when they add another. - change versus add. These were the ideas I had that drove my sketch in regards to the main author:
|
OK, I see this, but then what does the interface look like when you select "Change" on the correspondence author? Is it a dropdown? What do the options look like? Are they the author's names? Also with regards to copy, I think we should maintain the label "Correspondence Author" and make sure this is consistent with labels elsewhere in the interface. I think most places use "Correspondence Author" but some I know of use "Primary", and we should get rid of the discrepancy if we are thinking this carefully about what to call it in this interface. |
Few questions/comments Totally agree that this page had a lot of redundancies and this is a great direction!
|
I feel like the text in my version covers this though the copy might want to be re-written. Do you think its not easier to give the author the option to easily add themselves rather than ask them to search for themselves? Most journals have the setting to make the submitted an author automatically so most don't see this. |
Ah, I did not realise that this was a default situation and that's why you have it rather than just a more universal "add author". I could not pick that up from Steph's diagram. Only when I went into Janeway itself did I understand because the copy reads: Hmm. This is a conundrum! My concern is that we are asking them too many things at once in this one block. Are we asking them to choose between two columns where it is Maybe that level of complexity is fine. It is still an improvement |
I am not a fan of the 'add self as author' being on the same level as the 'add author' but I couldn't think of something better so kept it. I do think if you are currently listed as an author this should then be hidden as an option. In general, all options should be hidden from contexts where they don't do anything (add self if self already present, move up if at top, move down if at bottom, etc). |
It is hidden if you’re an author. |
out of interest, can you submit and be the correspondence person without being an author at all? |
Thinking about it probably the best solution to my mind is to have the account automatically there as an author on the screen, with the ability to remove it. |
We had a thorough discussion of this in the design meeting, and came to consensus about a number of things:
Here's an approximation (note a few differences with what's described above!): |
There is a setting for this already - I think we should toggle it to on by default though. |
I'm closing #4306 as it is now covered by this work.
|
Currently the author submission screen is spread across two columns which doesn't give us a lot of room to display information especially now that we are adding ROR and credit taxonomy information. This change would also be good for consistency as all other submission interfaces are single column.
For reference here is the current screen:
The text was updated successfully, but these errors were encountered: