Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linting standards for software-developer-tool #117

Open
xtanion opened this issue May 15, 2023 · 6 comments · May be fixed by #210
Open

Linting standards for software-developer-tool #117

xtanion opened this issue May 15, 2023 · 6 comments · May be fixed by #210
Assignees
@xtanion

Comments

@xtanion
Copy link
Contributor

xtanion commented May 15, 2023 •
edited
Loading

There are various linting standards in python.
Most commonly used are:

  • PEP8
  • Flake8
  • Pylint

We need to discuss on which linting format do we want to use.
@arshPratap
Copy link
Member

@xtanion this could be good.. Will prove immensely useful in the longer run.. I would love to see your work on this

@arshPratap arshPratap assigned arshPratap and xtanion and unassigned arshPratap May 16, 2023
@arshPratap
Copy link
Member

@xtanion just a note.. I saw your discussions on slack regarding the same.. Why don't you start with a draft PR for this and then we can all look into this and find the best possible route for this issue as I believe this will prove extremely beneficial in the future when the codebase expands

@xtanion
Copy link
Contributor Author

xtanion commented May 16, 2023 •
edited
Loading

Sure @arshPratap, I'll create a draft PR as soon as possible. Should I go ahead with using the Flake8 format?

@pleia2 pleia2 mentioned this issue May 17, 2023
Closed
@Ash-2k3 Ash-2k3 mentioned this issue May 1, 2024
Closed
@Ash-2k3
Copy link
Contributor

Ash-2k3 commented May 2, 2024

I have opened a PR for this issue, PTAL when you are free, thanks :)

@pleia2, @rachejazz

@pleia2
Copy link
Contributor

pleia2 commented May 8, 2024

Agreed to move forward with Flake8 at May 8th meeting.

@deveshidwivedi
Copy link
Collaborator

Is this open to work on? @pleia2 @arshPratap @xtanion

@deveshidwivedi deveshidwivedi linked a pull request Jun 19, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xtanion xtanion

Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@pleia2 @arshPratap @xtanion @Ash-2k3 @deveshidwivedi