Skip to content

Replace OpenMOC comparisons with RandomRay runs #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
2 tasks
pshriwise opened this issue Feb 27, 2025 · 2 comments
Open
2 tasks

Replace OpenMOC comparisons with RandomRay runs #26

pshriwise opened this issue Feb 27, 2025 · 2 comments

Comments

@pshriwise
Copy link
Contributor

OpenMOC, while nifty, has been giving our notebook CI a lot of trouble. Now that we have an MOC-like solver in OpenMC itself, it's probably time to update these comparison runs to use random ray instead.

The openmoc package is imported in the following notebooks:

  • mgxs-part-ii.ipynb
  • mgxs-part-iii.ipynb
@pshriwise
Copy link
Contributor Author

..though I'm realizing now that we may want to review the notebooks as there are correction factors that OpenMOC can use that might be relevant in these examples.

@jtramm
Copy link

jtramm commented Mar 2, 2025

After a quick look through, the main thing that jumps out to me is the use of transport corrected XS data. It should be pretty trivial to have the random ray solver use transport data instead of total if it's available in the mgxs.h5 file, so should just be a few lines of change we'd need to make. We could also add in Geoff's transport stabilization technique as well, should be easy to apply, and helps prevent stability issues arising from transport XS data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants