Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delayed neutrons are emitted promptly #3037

Closed
gridley opened this issue Jun 12, 2024 · 2 comments
Closed

Delayed neutrons are emitted promptly #3037

gridley opened this issue Jun 12, 2024 · 2 comments
Labels

Comments

@gridley
Copy link
Contributor

gridley commented Jun 12, 2024

Bug Description

I have not written any test cases, but we can see that in physics.cpp's sample_fission_neutron, in the delayed case, the decay time is not sampled and added on to the site's time entry.

To resolve

Sample a decay time for the precursor, and add that value to site.time. This alters the random number stream, so some means of preserving the prior RNG stream would be needed, too.

@gridley gridley added the Bugs label Jun 12, 2024
@ilhamv
Copy link

ilhamv commented Jul 23, 2024

This one is addressed in #2898.

As for the changing random number stream, the plan is to group the PR along with other PRs that also change the stream, like #2992, and then revise the regression test keys (as discussed in #2898).

@gridley
Copy link
Contributor Author

gridley commented Jul 23, 2024

Closing b/c this is a duplicate. Doh! I will review your code after I submit my PhD thesis around August 13, Ilham! Sorry your stuff has stayed open for so long. It's not a lot of code, but I need to take a little more time to understand exactly what it's doing fully.

@gridley gridley closed this as completed Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants