Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update guidance on build from source to retrieve python dependencies #3146

Open
MicahGale opened this issue Sep 27, 2024 · 2 comments
Open

Comments

@MicahGale
Copy link
Contributor

MicahGale commented Sep 27, 2024

I was recently installing from source to review #3140 following the official guide. However, when I tried to import openmc I got an ImportError for endf. This is because I never had to run pip to install this dependency.

I think the build process was not properly updated with the migration to pyproject.toml. The documentation should add a step to include pip install ., unless this is supposed to be handled by cmake but is not being handled.

@ahnaf-tahmid-chowdhury
Copy link
Contributor

The openmc Python package must be installed separately. The easiest way to install it is using pip. From the root directory of the OpenMC repository, run:

python -m pip install .

You may find this at the bottom of the documentation. However, to mitigate this issue, we have an active PR open, #3087

@MicahGale
Copy link
Contributor Author

Oh I see that now. I think this should be in the main code block because after make install it feels like you are done so I just stop reading. (Ok I never read the comments to begin with).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants