Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension of fluence to dose conversion factors - ICRP-74 ambient dose H*(10) and other possible values. #3216

Open
rworrall-ukaea opened this issue Dec 5, 2024 · 4 comments

Comments

@rworrall-ukaea
Copy link

Addition of H*(10) and other fluence to dose factors

It would be useful to have H*(10) dose factors for safety case analysis, and I would like to add a range of fluence to dose factors to the currently available.

This issue has previously been raised and partly addressed

This issue has been reaised previously but doens't seem to have made it into the current develop branch.

#3174

c0acc28

Compatibility

This would be an extension and clean up of the current features. Re-structure the folder "effective_dose" to a generic "fluence_to_dose_factors", and then have effective and ambient dose values. Update "dose_coefficients" method to allow access to ICRP-74/116/119 and dose type. Allow extension to other dose factors.

@rworrall-ukaea
Copy link
Author

@shimwell @jon-proximafusion you previously looked at this, do you know what the state of previous work is?

@shimwell
Copy link
Member

shimwell commented Dec 5, 2024

This PR got merged and it included additional coefficients, looks like we have just two available 'icrp74', 'icrp116' currently

Specifying the data_source argument when calling dose_coefficients allows one to get different coefficients

Link to source code

def dose_coefficients(particle, geometry='AP', data_source='icrp116'):

Link to test showing usage https://github.com/openmc-dev/openmc/blob/develop/tests/unit_tests/test_data_dose.py

We do have the framework for adding other dose coefficients, just by making a new folder here and adding the particle txt files within

@shimwell
Copy link
Member

shimwell commented Dec 5, 2024

So two of the dose coefficients you mention are already available in openmc (ICRP-74/116)

The other one you mention ICRP 119 I did actually try to add this originally but the PR didn't quite make it as we couldn't find a use for 119 compared to 116.

So if you can give a good answer to @paulromano question and then we can certainly add 119 data.

I would be happy to grab the 119 data from my old PR and make a new PR if that helps

@rworrall-ukaea
Copy link
Author

Thanks Jon. H*(10) isn't available, only the 6 ICRP-74 and ICRP-116 AP, PA LLAT, RLAT, ROT and ISO effective fluence to dose factors. H*(10) is quite commonly used. ICRP-119 could be added and little extra cost, although it might not be widely used.

If we re-structure the folders to be more generic, we could easily add any number of factors. I think cahnging the format of the factors from these fixed with text files to perhaps a json for each set could also make the code cleaner and less verbose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants