Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When DAGMC fails during initialisation OpenMC should halt #3224

Open
makeclean opened this issue Dec 14, 2024 · 0 comments
Open

When DAGMC fails during initialisation OpenMC should halt #3224

makeclean opened this issue Dec 14, 2024 · 0 comments
Labels

Comments

@makeclean
Copy link
Contributor

When initialising a DAGMC problem, there can be malformed geometries which do not conform to the requirements of DAGMC, e.g. a user may have forgotten to imprint, or surfaces could be missing, sometimes init_OBBTree() can fail, currently this failure is echoed to screen, but no further action is taken. We should likely catch the error and terminate. Right now we use the MOAB macro MB_CHK_ERR_CONT, maybe we either should raise an exception or maybe switch to a different macro such as MB_SET_GLB_ERR. Either way, right now OpenMC happily carries on.

@makeclean makeclean added the Bugs label Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant