Skip to content

fix: prevent removing clusterRef or requestRef from AccessRequest #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2025
Merged

fix: prevent removing clusterRef or requestRef from AccessRequest #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions api/clusters/v1alpha1/accessrequest_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ import (
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
)

// +kubebuilder:validation:XValidation:rule="!has(oldSelf.clusterRef) || has(self.clusterRef)", message="clusterRef may not be removed once set"
// +kubebuilder:validation:XValidation:rule="!has(oldSelf.requestRef) || has(self.requestRef)", message="requestRef may not be removed once set"
type AccessRequestSpec struct {
// ClusterRef is the reference to the Cluster for which access is requested.
// If set, requestRef will be ignored.
Expand Down
5 changes: 5 additions & 0 deletions api/crds/manifests/clusters.openmcp.cloud_accessrequests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,11 @@ spec:
required:
- permissions
type: object
x-kubernetes-validations:
- message: clusterRef may not be removed once set
rule: '!has(oldSelf.clusterRef) || has(self.clusterRef)'
- message: requestRef may not be removed once set
rule: '!has(oldSelf.requestRef) || has(self.requestRef)'
status:
description: AccessRequestStatus defines the observed state of AccessRequest
properties:
Expand Down