Skip to content

Commit 05af4a0

Browse files
authored
fix: members table fix (#259)
1 parent 077ef99 commit 05af4a0

File tree

11 files changed

+14
-15
lines changed

11 files changed

+14
-15
lines changed

src/components/Dialogs/CreateProjectDialogContainer.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ export function CreateProjectDialogContainer({
5353

5454
useEffect(() => {
5555
if (username) {
56-
setValue('members', [{ name: username, role: MemberRoles.admin, kind: 'User' }]);
56+
setValue('members', [{ name: username, roles: [MemberRoles.admin], kind: 'User' }]);
5757
}
5858
if (!isOpen) {
5959
clearForm();

src/components/Dialogs/CreateWorkspaceDialogContainer.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ export function CreateWorkspaceDialogContainer({
6868

6969
useEffect(() => {
7070
if (username) {
71-
setValue('members', [{ name: username, role: MemberRoles.admin, kind: 'User' }]);
71+
setValue('members', [{ name: username, roles: [MemberRoles.admin], kind: 'User' }]);
7272
}
7373
if (!isOpen) {
7474
clearForm();

src/components/Members/AddEditMemberDialog.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ export const AddEditMemberDialog: FC<AddEditMemberDialogProps> = ({
9191
if (memberToEdit) {
9292
reset({
9393
name: memberToEdit.name,
94-
role: memberToEdit.role || MemberRoles.view,
94+
role: memberToEdit.roles?.[0] || MemberRoles.view,
9595
accountType: memberToEdit.kind === 'User' ? 'User' : 'ServiceAccount',
9696
namespace: memberToEdit?.namespace || '',
9797
});
@@ -111,7 +111,7 @@ export const AddEditMemberDialog: FC<AddEditMemberDialogProps> = ({
111111

112112
const newMember: Member = {
113113
name: trimmedName,
114-
role: data.role,
114+
roles: [data.role],
115115
kind: data.accountType,
116116
...(data.accountType === 'ServiceAccount' && data.namespace && { namespace: data.namespace }),
117117
};

src/components/Members/MemberTable.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -111,11 +111,10 @@ export const MemberTable: FC<MemberTableProps> = ({
111111
</Infobox>
112112
);
113113
}
114-
115114
const data: MemberTableRow[] = members.map((m) => {
116115
return {
117116
email: m.name,
118-
role: MemberRolesDetailed[m.role as MemberRoles]?.displayValue,
117+
role: MemberRolesDetailed[m.roles?.[0] as MemberRoles]?.displayValue ?? m.roles?.toString(),
119118
kind: m.kind,
120119
namespace: m.namespace ?? '',
121120
_member: m,

src/components/Wizards/CreateManagedControlPlane/CreateManagedControlPlaneWizardContainer.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ export const CreateManagedControlPlaneWizardContainer: FC<CreateManagedControlPl
111111

112112
useEffect(() => {
113113
if (user?.email && isOpen) {
114-
setValue('members', [{ name: user.email, role: MemberRoles.admin, kind: 'User' }]);
114+
setValue('members', [{ name: user.email, roles: [MemberRoles.admin], kind: 'User' }]);
115115
}
116116
if (!isOpen) {
117117
clearFormFields();

src/components/Wizards/CreateManagedControlPlane/SummarizeStep.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ export const SummarizeStep: React.FC<SummarizeStepProps> = ({ watch, projectName
3737
<br />
3838
<List headerText={t('common.members')}>
3939
{watch('members').map((member) => (
40-
<ListItemStandard key={member.name} text={member.name} additionalText={member.role} />
40+
<ListItemStandard key={member.name} text={member.name} additionalText={member.roles?.[0]} />
4141
))}
4242
</List>
4343
<br />

src/lib/api/types/crate/createManagedControlPlane.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ export const CreateManagedControlPlane = (
135135
authorization: {
136136
roleBindings:
137137
optional?.members?.map((member) => ({
138-
role: member.role,
138+
role: member.roles?.[0],
139139
subjects: [
140140
{
141141
kind: member.kind as AccountType,

src/lib/api/types/crate/createProject.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,10 +45,10 @@ export const CreateProject = (
4545
},
4646
spec: {
4747
members:
48-
optional?.members?.map(({ kind, namespace, role, name }) => ({
48+
optional?.members?.map(({ kind, namespace, roles, name }) => ({
4949
kind,
5050
name,
51-
roles: [role],
51+
roles,
5252
namespace: kind === 'ServiceAccount' ? (namespace ?? 'default') : undefined,
5353
})) ?? [],
5454
},

src/lib/api/types/crate/createWorkspace.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,10 +48,10 @@ export const CreateWorkspace = (
4848
},
4949
spec: {
5050
members:
51-
optional?.members?.map(({ kind, namespace, role, name }) => ({
51+
optional?.members?.map(({ kind, namespace, roles, name }) => ({
5252
kind,
5353
name,
54-
roles: [role],
54+
roles,
5555
namespace: kind === 'ServiceAccount' ? (namespace ?? 'default') : undefined,
5656
})) ?? [],
5757
},

src/lib/api/types/crate/listWorkspaces.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,6 @@ export function isWorkspaceReady(workspace: ListWorkspacesType): boolean {
2222
export const ListWorkspaces = (projectName?: string): Resource<ListWorkspacesType[]> => {
2323
return {
2424
path: `/apis/core.openmcp.cloud/v1alpha1/namespaces/project-${projectName}/workspaces`,
25-
jq: '[.items[] | {metadata: .metadata | {name, namespace, annotations, deletionTimestamp}, status: .status, spec: .spec | {members: [.members[] | {name, roles}]}}]',
25+
jq: '[.items[] | {metadata: .metadata | {name, namespace, annotations, deletionTimestamp}, status: .status, spec: .spec | {members: [.members[] | {name, roles, kind, namespace}]}}]',
2626
};
2727
};

0 commit comments

Comments
 (0)