Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in preprocessing pipeline may go undetected until after search #132

Open
PGijsbers opened this issue Nov 1, 2021 · 0 comments
Open
Labels
Milestone

Comments

@PGijsbers
Copy link
Member

With the minimal example of #131 an error is thrown after search, even though the error arises in the (prepended) preprocessing pipeline. Any error generated by the preprocessing steps that are determined globally should be caught before search.
There are multiple ways to catch this early, but a fit_transform on the preprocessing pipeline is probably sufficient for now.
Ideally we cache the outcome but that should probably be added only after revising the compute back-end (#3).

@PGijsbers PGijsbers added the bug label Nov 1, 2021
@PGijsbers PGijsbers added this to the v22.1+ milestone Jul 27, 2022
@PGijsbers PGijsbers modified the milestones: v22.1+, v22.1 Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant