Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type hints #28

Open
PGijsbers opened this issue Nov 29, 2018 · 2 comments
Open

Add type hints #28

PGijsbers opened this issue Nov 29, 2018 · 2 comments
Labels
Code Quality For improvements to code quality, such as improving readability, code re-use or increasing coverage. good first issue
Milestone
v22.1

Comments

@PGijsbers
Copy link
Member

Add type hint to function calls to make code easier to read, as per pep 484.
Currently will touch up old code whenever I happen to work on it, but this means there's still work left to do.
@PGijsbers PGijsbers added enhancement An improvement to an existing component, e.g. optimization. good first issue labels Nov 29, 2018
@PGijsbers
Copy link
Member Author

Not sure how or if I should specify array-likes (when multiple datatypes such as np.array, list and pd.DataFrame are all allowed).

@PGijsbers PGijsbers added Code Quality For improvements to code quality, such as improving readability, code re-use or increasing coverage. and removed enhancement An improvement to an existing component, e.g. optimization. labels Jul 9, 2019
@PGijsbers
Copy link
Member Author

Uncomment the following options in the mypy.ini file to find underdocumented definitions:

# warn_return_any=True
# warn_unreachable=True

#disallow_incomplete_defs=True
#disallow_untyped_defs=True

@PGijsbers PGijsbers added this to the v22.0.0 milestone Jul 27, 2022
@PGijsbers PGijsbers modified the milestones: v22.0.0, v22.1 Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Code Quality For improvements to code quality, such as improving readability, code re-use or increasing coverage. good first issue
Projects
None yet
Milestone
v22.1
Development

No branches or pull requests
1 participant
@PGijsbers