Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pre-commit configured incorrectly #1030

Closed
PGijsbers opened this issue Feb 22, 2021 · 0 comments · Fixed by #1129
Closed

pre-commit configured incorrectly #1030

PGijsbers opened this issue Feb 22, 2021 · 0 comments · Fixed by #1129
Labels
CI About continious integration Good First Issue Issues suitable for people new to contributing to openml-python!

Comments

@PGijsbers
Copy link
Collaborator

The files on which the mypy and flake hooks operate are configured incorrectly with globs, see pre-commit#1702: [WARNING] The 'files' field in hook 'mypy' is a regex, not a glob -- matching '/*' probably isn't what you want here.

These need to be updated (and work with both unix and windows paths).
@PGijsbers PGijsbers added Good First Issue Issues suitable for people new to contributing to openml-python! CI About continious integration labels Feb 22, 2021
@PGijsbers PGijsbers mentioned this issue Mar 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CI About continious integration Good First Issue Issues suitable for people new to contributing to openml-python!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Precommit update openml/openml-python
1 participant
@PGijsbers