-
-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checking active datasets #671
Comments
The distinction here is that you no longer check whether the dataset id exists at all. I.e. a dataset which is inactive and one that does not exist altogether would be be returned as |
@PGijsbers you understood the idea right and the point you are making is valid. Then, I would propose to further improve my initial idea and only In the end we can just compare |
I definitely think we should raise an error if the passed dataset id does not exist, consider the following use case of the function: dids = [ ... some ids ... ]
dids_active = check_datasets_active(dids)
if all(dids_active.values()):
# All datasets are active, do something
... If there is a more efficient way to retrieve active status for the datasets from the server, I am all for it.
is absolutely fine as in good-weather scenarios the simple length comparison should be negligible in terms of performance. Adding a parameter |
openml-python/openml/datasets/functions.py
Lines 295 to 296 in 3dc6dee
Maybe we should
list_datasets(status='active')
and if adataset_id
from the iterable ofdataset_ids
that we want to check is in the results, we can mark it as True, otherwise False.The text was updated successfully, but these errors were encountered: