Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename arguments of list_evaluations to indicate they expect lists of ids #804

Closed
PGijsbers opened this issue Oct 8, 2019 · 1 comment
Closed
Assignees
Labels
Documentation Good First Issue Issues suitable for people new to contributing to openml-python!

Comments

@PGijsbers
Copy link
Collaborator

PGijsbers commented Oct 8, 2019

See also #796. It was a step forward, but the argument names still don't convey that we are looking for a list (i.e. argument name should be plural) or ids as opposed to OpenML objects (e.g. by a suffix _id).

I would argue that we also should update the type hints (to Optional[List[Union[str, int]]]) and add parameter descriptions in the docstring.

@mfeurer
Copy link
Collaborator

mfeurer commented Jul 14, 2020

Added via #933

@mfeurer mfeurer closed this as completed Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Good First Issue Issues suitable for people new to contributing to openml-python!
Projects
None yet
Development

No branches or pull requests

4 participants