-
-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better error messages for string constraints #920
Comments
The string must be quoted if the name includes spaces (from https://waikato.github.io/weka-wiki/formats_and_processing/arff_stable/)
I don't like the idea of meddling with data provided by the user. I prefer the idea of having better error messages. I opened an issue in the arff parser: renatopp/liac-arff#110 |
I'm not convinced that this is about ARFF parsing... Apart from anything else, the user is not providing ARFF input in the above code. |
Thanks a lot, you're totally right. I assumed that this happened during conversion of the dataset to ARFF, but it fails before. Then the issue is actually that we're giving a custom error message to not have to upload and wait for a server error message. But yes, we could basically check which characters are illegal and print that. |
Description
I often hear users complain that they don't know what to do when
create_dataset
complains about string constraints. Typically this is because people used a space (' ') in the name (I'm not actually sure why we don't allow that) or a special character in the description.Could we maybe return a more informative general error message, like 'Character ' ' is not allowed in field x'?
Alternatively, let the python API replace spaces in the dataset name with underscores automatically, and replace special characters with '?' or ' '.
Steps/Code to Reproduce
Example:
Expected Results
A more informative general error message, like 'Character ' ' is not allowed in field x'?
Or: replace the 'bad' characters automatically
Actual Results
A hard-to-read stack trace:
Versions
Darwin-19.4.0-x86_64-i386-64bit
Python 3.7.3 (default, Mar 27 2019, 16:54:48)
[Clang 4.0.1 (tags/RELEASE_401/final)]
NumPy 1.18.4
SciPy 1.4.1
Scikit-Learn 0.23.1
OpenML 0.11.0dev
The text was updated successfully, but these errors were encountered: