-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Agency: telemetry endpoint returns a success in case of failures #462
Comments
Flagging @avatarneil to investigate best-practice in bulk REST APIs |
I also think that solution 1 is too restrictive. Good telemetry should always be accepted IMHO. |
@schnuerle We haven't had time to discuss this issue in the working group. I will try to discuss this on Thursday, but I think it is low priority and could be pushed to 1.1.0 if there are more important matters to discuss. However, If we do push it to 1.1.0, I think we should merge #461 (or any other specific response format) to have something specified in the spec and make the response machine-readable. |
@schnuerle I updated #461 to solve this issue. Since #451 was merged, I'm closing the issue. |
Is your feature request related to a problem? Please describe.
The Agency spec defines responses for the telemetry endpoint as follows:
This means that when the server fails to do what was expected of it (save new telemetries), it returns a success message.
Describe the solution you'd like
201 Success responses should only be used if all the telemetries were added.
I can see several alternatives if at least one telemetry could not be saved:
Is this a breaking change
A breaking change would require consumers or implementors of the API to modify their code for it to continue to function (ex: renaming of a required field or the change in data type of an existing field). A non-breaking change would allow existing code to continue to function (ex: addition of an optional field or the creation of a new optional endpoint).
Impacted Spec
For which spec is this feature being requested?
agency
The text was updated successfully, but these errors were encountered: