-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version number is 1.0.x for 1.1.0 release #669
Comments
Tagging @thekaveman for review and feedback. Could be a simple PR to fix in upcoming 1.2.0 release. |
Thanks! I'm happy to put up a PR but it seems like 1.1.0 is baked and the next opportunity will be when the release-1.2.0 branch is created. |
Doh!! 😱 yes this is definitely a bug in the 1.1.0 schema, thank you for the find @paultbeck! This obviously must be fixed for the 1.2.0 release. Depending on the scope of 1.2.0 changes, it may make sense to release a hotfix 1.1.1 that updates the schemas for anyone wanting to stick to the 1.1.x line. Though this is likely overkill since 1.2.0 is non-breaking.
No need to wait until then - a PR against If there is a feeling that a 1.1.1 hotfix is warranted, a PR against ETA: unfortunately this affects Provider and Policy, as both schemas use the common version definition. |
I'll definitely make a PR and merge to It could also be good to make a PR and hotfix the 1.1.0 release with 1.1.1 against Thank you for catching this @paultbeck - it's something I should have seen when creating the release. We had a number of beta features which didn't have schema updates, so I wasn't giving the schema the attention it deserved. |
Fixed with #683 for 1.2.x. Are looking into doing a patch for 1.1.0 as well. |
Fixed for 1.1.1 with PR #699. Please review @paultbeck for accuracy. I will create the release tomorrow. |
Describe the bug
The schemas for provider endpoints in the release-1.1.0 branch seem to have 1.0.x versions, which prevents validating responses using the schemas in https://github.com/openmobilityfoundation/mobility-data-specification/tree/release-1.1.0/provider
To Reproduce
Expected behavior
Additional context
The release process seems to be very specific about how this is updated, but unless I'm mistaken, it wasn't done for 1.1.0.
The text was updated successfully, but these errors were encountered: