-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vehicle "heartbeat" #750
Comments
In the Vehicles endpoint, we could add a field At Spin we use this quite a bit internally. Our vehicles send indeed heartbeats back on a fairly frequent interval so we know they are still functional and connected to our backend. |
copying @ezmckinn comment here from #749 ezmckinn commented 8 days ago
|
I think from a city perspective hearing from scooters more frequently is better in order to adjust any counts (aka shorter lookback period). From the steering committees quick survey it seems most operators are getting an internal "heartbeat" at least every 10 minutes. |
Here is a comment we received from DC:
|
I like the idea of a |
@jiffyclub that sounds like two different changes, one for Vehicles and one for Status Changes. I think the Vehicles one is much more straightforward and might be limited work to add to the standard. For a status change of event_type |
I agree with @dirkdk on this point — a |
The issue with only putting a heartbeat into the /vehicles endpoint is that it's not part of the historical record available via the status changes endpoint. It can tell us about now, but not any other time. If we've pulled a broad time range of data from status changes and are compiling vehicle counts it's useful to have some signal in those events saying "this vehicle is still operational out there" even though it hasn't registered any other kind of event in the last week. Without a heartbeat in the status changes we're still stuck trying to negotiate lookback windows with different regions and operators, which this heartbeat is meant to address. (Or figuring out how to have a historical record from the /vehicles endpoint, which it is not meant to do.) |
I tried to put together a summary of the options we've discussed and the pros/cons of each: Heartbeats in /vehiclesProviders could put a Pros
Cons
Heartbeats in status changesCreate a new event type that providers would include in their status changes feeds once per day for each vehicle to indicate that they had contact with that vehicle at the time of the event, or maybe that they had had contact with the vehicle within X hours preceding the event time. Pros
Cons
|
Nice summary @jiffyclub. One clarification I think is /vehicles also returns vehicles NOT in the PROW for the most part (90 minutes till removal for some states), which affects a con in the first option. "Since all states are returned, care should be taken to filter out states not in the PROW if doing vehicle counts. For the states elsewhere and removed which include vehicles not in the PROW but provide some operational clarity for agencies, these must only persist in the feed for 90 minutes before being removed." |
Oh nice @schnuerle, I'm not sure I realized we'd made that clarification into the spec. I updated the point above. In practice, I'm not sure we often see removed vehicles in the /vehicles feed, but I haven't done a wide survey of that (and very few operators are on MDS 1.2, when the clarification was added). |
Instead of requesting a vehicle heartbeat to help standardize a lookback period we're going to move forward with changing the vehicle state "unknown" and incorporating a "last heard" concept. See proposal to change vehicle state "unknown" and notes from 2022.10.13 WG meeting |
Is your feature request related to a problem? Please describe.
We would like to "hear" from vehicles who are parked in the PROW to know if they are still there and ok. Currently we're making assumptions about their location and state - using a lookback period (#749) to determine when vehicles are lost.
Describe the solution you'd like
The concept of a vehicle "heartbeat" where we can verify through communication with the vehicle that it's still out there. Perhaps this can be integrated into MDS Provider /vehicles .
Is this a breaking change
Impacted Spec
provider
Describe alternatives you've considered
n/a
Additional context
see 2022.02.17 working group discussion
The text was updated successfully, but these errors were encountered: