Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide on appropriate abstain emoji; add to contribution guide #374

Open
aaraney opened this issue Dec 6, 2021 · 4 comments
Open

Decide on appropriate abstain emoji; add to contribution guide #374

aaraney opened this issue Dec 6, 2021 · 4 comments

Comments

@aaraney
Copy link
Contributor

aaraney commented Dec 6, 2021

@cmbarton clarified during the 12/6/2021 meeting that there are three voting states: yes, no, or abstain. In the 'How to Vote on a Pull Request' section of the contribution guide there are only two options 👍 or 👎. Can we decide and add an abstain emoji?

@aaraney
Copy link
Contributor Author

aaraney commented Dec 6, 2021

My proposal is 😕.

@alee
Copy link
Member

alee commented Dec 6, 2021

I like 😕 but 👀 might work too

@aaraney
Copy link
Contributor Author

aaraney commented Dec 6, 2021

Hahah, I really like 👀. I think you've converted me.

@cmbarton
Copy link
Contributor

cmbarton commented Dec 7, 2021

After this meeting, I think we will need to have a more well defined method of voting. We an pick our own emoji's for abstain like this 🤷 U+1F937 SHRUG, decimal: 129335, HTML: &#129335

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

3 participants