Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SetPlayerSkin is not working at SA-MP Launcher APK #1007

Open
hiwyn opened this issue Oct 19, 2024 · 11 comments
Open

SetPlayerSkin is not working at SA-MP Launcher APK #1007

hiwyn opened this issue Oct 19, 2024 · 11 comments
Assignees
Labels
bug Something isn't working nightly

Comments

@hiwyn
Copy link

hiwyn commented Oct 19, 2024

SetPlayerSkin is not working on SA-MP Launcher
[mostly used sa-mp APK, more than 10.000.000 downloads]

  • for the others players: they see the right skin for the target player
  • for the target player: he see himself with CJ skin (id: 0) and can run with CJ speed even with UsePlayerPedAnims() disabled

There is any work around to fix it?

@hiwyn hiwyn added bug Something isn't working nightly labels Oct 19, 2024
@AmyrAhmady
Copy link
Member

It works for me with an empty simple script and only 2 players in game

You must provide a script for me to reproduce this bug

@NexiusTailer
Copy link
Contributor

@hiwyn maybe you tested it on release build? It was most likely fixed in latest nightly.

@Duduzera1997
Copy link

Duduzera1997 commented Nov 20, 2024

+1

Here the SetPlayerSkin doesn't work too and the Android clients only use the skin 0 by default.

@NexiusTailer
Copy link
Contributor

+1

Here the SetPlayerSkin doesn't work too and the Android clients only use the skin 0 by default.

The same question again:

maybe you tested it on release build? It was most likely fixed in latest nightly

@Duduzera1997
Copy link

Duduzera1997 commented Nov 20, 2024

@NexiusTailer oh, sorry, I discovered that 'nightly' is a build of the main/master branch is a few hours ago, so, after building it worked out fine.

Just for future history: @AmyrAhmady recommended me in discord to use SetSpawnInfo instead of SetPlayerSkin to test and started to work better with the current published release (v1.3.1.2748) but to work out with my old code just on nightly.

Thanks for your help!

@hiwyn
Copy link
Author

hiwyn commented Feb 15, 2025

sorry this long, i went back to samp, i was losing a lot of players

but i had this problem with a code like:

public OnPlayerRequestClass(playerid, classid)
{
    SetPlayerVirtualWorldEx(playerid, 111);
    SetPlayerCameraLookAt(playerid, 2.9660,28.3319,1200.0781);
    SetPlayerInteriorEx(playerid,1);
    SetPlayerFacingAngle(playerid,2.2269);
    SetSpawnInfo(playerid, 1, 29, 2.9660,30.3319,1200.0781,0.0, 0,0,0,0,0,0 );
    return SpawnPlayer(playerid);
}

public OnPlayerSpawn(playerid) {
    ...
    KillTimerEx(timerResetPlayerSkin[playerid]);
    timerResetPlayerSkin[playerid] = SetTimerEx("SetPlayerSkin", 5000, false, "ii", playerid, skinid);
}

on commit 8c246565edd6363ee55dfd01043f5c0c48f92f09

Merge: 596ece7a 43cd406a
Author: iAmir <amirabgta@gmail.com>
Date:   Thu Oct 31 14:56:03 2024 +0330

    Merge pull request #1016 from openmultiplayer/hual/player_objects_crash_fix
    
    Fix moving player objects crash due to out-of-order destruction

@AmyrAhmady
Copy link
Member

Why are you using an old build like that, while even our official public release is newer?

@hiwyn
Copy link
Author

hiwyn commented Feb 16, 2025

Why are you using an old build like that, while even our official public release is newer?

I just saying what version i was using, i went back to samp, i couldn't stop to support the most used android apk (10 mi+ downloads)
I'l try to test the new one some day, but none of commits after that mention this problem

@NexiusTailer
Copy link
Contributor

but none of commits after that mention this problem

It was fixed long time ago:
#978

@hiwyn
Copy link
Author

hiwyn commented Feb 17, 2025

but none of commits after that mention this problem

It was fixed long time ago: #978

i don't think so, this commit is from Sep 8, 2024
the branch i was using when i was using open mp was Oct 31, 2024

@NexiusTailer
Copy link
Contributor

but none of commits after that mention this problem

It was fixed long time ago: #978

i don't think so, this commit is from Sep 8, 2024 the branch i was using when i was using open mp was Oct 31, 2024

Ok, so what about finally managing to update a few files in your server path to test on the latest release available?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working nightly
Projects
None yet
Development

No branches or pull requests

4 participants