fix: windows compat

Author: pieh

src/build/content/server.ts

@@ -10,8 +10,8 @@ import {
   writeFile,
 } from 'node:fs/promises'
 import { createRequire } from 'node:module'
-import { dirname, join, relative, sep } from 'node:path'
-import { join as posixJoin, sep as posixSep } from 'node:path/posix'
+import { dirname, join, sep } from 'node:path'
+import { join as posixJoin, relative as posixRelative, sep as posixSep } from 'node:path/posix'
 
 import { trace } from '@opentelemetry/api'
 import { wrapTracer } from '@opentelemetry/api/experimental'
@@ -26,7 +26,11 @@ import type { PluginContext, RequiredServerFilesManifest } from '../plugin-conte
 
 const tracer = wrapTracer(trace.getTracer('Next runtime'))
 
-const toPosixPath = (path: string) => path.split(sep).join(posixSep)
+const toPosixPath = (path: string) =>
+  path
+    .replace(/^\\+\?\\+/, '') // https://github.com/nodejs/node/blob/81e05e124f71b3050cd4e60c95017af975568413/lib/internal/fs/utils.js#L370-L372
+    .split(sep)
+    .join(posixSep)
 
 function isError(error: unknown): error is NodeJS.ErrnoException {
   return error instanceof Error
@@ -173,6 +177,7 @@ export const copyNextServerCode = async (ctx: PluginContext): Promise<void> => {
  * @returns
  */
 async function recreateNodeModuleSymlinks(src: string, dest: string, org?: string): Promise<void> {
+  console.log('recreateNodeModuleSymlinks', { src, dest, org })
   const dirents = await readdir(join(src, org || ''), { withFileTypes: true })
 
   await Promise.all(
@@ -309,17 +314,21 @@ export const copyNextDependencies = async (ctx: PluginContext): Promise<void> =>
   await tracer.withActiveSpan('copyNextDependencies', async () => {
     const promises: Promise<void>[] = []
 
-    const nodeModulesLocationsInStandalone = new Set<string>()
+    const nodeModulesLocations = new Set<{ source: string; destination: string }>()
     const commonFilter = ctx.constants.IS_LOCAL ? undefined : nodeModulesFilter
 
-    const dotNextDir = join(ctx.standaloneDir, ctx.nextDistDir)
+    const dotNextDir = toPosixPath(join(ctx.standaloneDir, ctx.nextDistDir))
+
+    const standaloneRootDir = toPosixPath(ctx.standaloneRootDir)
+    const outputFileTracingRoot = toPosixPath(ctx.outputFileTracingRoot)
 
     await cp(ctx.standaloneRootDir, ctx.serverHandlerRootDir, {
       recursive: true,
       verbatimSymlinks: true,
       force: true,
-      filter: async (sourcePath: string) => {
-        if (sourcePath === dotNextDir) {
+      filter: async (sourcePath: string, destination: string) => {
+        const posixSourcePath = toPosixPath(sourcePath)
+        if (posixSourcePath === dotNextDir) {
           // copy all except the distDir (.next) folder as this is handled in a separate function
           // this will include the node_modules folder as well
           return false
@@ -328,18 +337,23 @@ export const copyNextDependencies = async (ctx: PluginContext): Promise<void> =>
         if (sourcePath.endsWith('node_modules')) {
           // keep track of node_modules as we might need to recreate symlinks
           // we are still copying them
-          nodeModulesLocationsInStandalone.add(sourcePath)
+          nodeModulesLocations.add({
+            source: posixSourcePath,
+            destination: toPosixPath(destination),
+          })
         }
 
         // finally apply common filter if defined
         return commonFilter?.(sourcePath) ?? true
       },
     })
 
-    for (const nodeModulesLocationInStandalone of nodeModulesLocationsInStandalone) {
-      const relativeToRoot = relative(ctx.standaloneRootDir, nodeModulesLocationInStandalone)
-      const locationInProject = join(ctx.outputFileTracingRoot, relativeToRoot)
-      const locationInServerHandler = join(ctx.serverHandlerRootDir, relativeToRoot)
+    for (const {
+      source: nodeModulesLocationInStandalone,
+      destination: locationInServerHandler,
+    } of nodeModulesLocations) {
+      const relativeToRoot = posixRelative(standaloneRootDir, nodeModulesLocationInStandalone)
+      const locationInProject = posixJoin(outputFileTracingRoot, relativeToRoot)
 
       promises.push(recreateNodeModuleSymlinks(locationInProject, locationInServerHandler))
     }

src/build/plugin-context.ts

@@ -2,7 +2,7 @@ import { existsSync, readFileSync } from 'node:fs'
 import { readFile } from 'node:fs/promises'
 import { createRequire } from 'node:module'
 import { join, relative, resolve, sep } from 'node:path'
-import { join as posixJoin, relative as posixRelative, sep as posixSep } from 'node:path/posix'
+import { join as posixJoin, relative as posixRelative } from 'node:path/posix'
 import { fileURLToPath } from 'node:url'
 
 import type {
@@ -20,8 +20,6 @@ import type {
 } from 'next-with-cache-handler-v2/dist/build/index.js'
 import { satisfies } from 'semver'
 
-const toPosixPath = (path: string) => path.split(sep).join(posixSep)
-
 const MODULE_DIR = fileURLToPath(new URL('.', import.meta.url))
 const PLUGIN_DIR = join(MODULE_DIR, '../..')
 const DEFAULT_PUBLISH_DIR = '.next'
@@ -100,7 +98,7 @@ export class PluginContext {
     }
 
     if (!this.relativeAppDir.includes('..')) {
-      // For newer Next.js versions this is not written to the output directly anymore, but we can use appDir and relativeAppDir to compute it.
+      // For newer Next.js versions outputFileTracingRoot is not written to the output directly anymore, but we can use appDir and relativeAppDir to compute it.
       // This assumes that relative app dir will never contain '..' segments. Some monorepos support workspaces outside of the monorepo root (verified with pnpm)
       // However Next.js itself have some limits on it:
       //  - turbopack by default would throw "Module not found: Can't resolve '<name_of_package_outside_of_root>'"
@@ -110,8 +108,7 @@ export class PluginContext {
       //      because parts of application would be outside of "standalone" directory
       //    - if it's not marked as external it will be included in next.js produced chunks
 
-      const depth =
-        this.relativeAppDir === '' ? 0 : toPosixPath(this.relativeAppDir).split(posixSep).length
+      const depth = this.relativeAppDir === '' ? 0 : this.relativeAppDir.split(sep).length
 
       const computedOutputFileTracingRoot = resolve(
         this.requiredServerFiles.appDir,