Skip to content

Commit d3f04c2

Browse files
committed
ci: remove attempt to run e2e on windows, that needs way more effort
1 parent 358727b commit d3f04c2

File tree

1 file changed

+7
-11
lines changed

1 file changed

+7
-11
lines changed

.github/workflows/run-tests.yml

Lines changed: 7 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -68,10 +68,10 @@ jobs:
6868
6969
e2e:
7070
needs: setup
71+
runs-on: ubuntu-latest
7172
strategy:
7273
fail-fast: false
7374
matrix:
74-
os: ${{ fromJson(needs.setup.outputs.os) }}
7575
version: ${{ fromJson(needs.setup.outputs.matrix) }}
7676
shard: [1, 2, 3, 4, 5]
7777
exclude:
@@ -82,7 +82,6 @@ jobs:
8282
- os: windows-2025
8383
version: "15.5.9"
8484

85-
runs-on: ${{ matrix.os }}
8685
steps:
8786
- uses: actions/checkout@v6
8887
- name: Resolve Next.js version
@@ -112,6 +111,7 @@ jobs:
112111
- uses: oven-sh/setup-bun@v2
113112
- name: setup pnpm/yarn
114113
run: |
114+
npm install -g corepack
115115
corepack enable
116116
shell: bash
117117
- name: Install Deno
@@ -126,7 +126,7 @@ jobs:
126126
NETLIFY_AUTH_TOKEN: ${{ secrets.NETLIFY_AUTH_TOKEN }}
127127
run: |
128128
# Control netlify-cli as a regular dev dep but expose it globally for test fixtures to use
129-
npm install -g "netlify-cli@$(npm list --json --depth=0 netlify-cli | jq -r '.dependencies["netlify-cli"].version')"
129+
npm install -g "netlify-cli@$(npm list --json --depth=0 netlify-cli | jq -r ".dependencies[\"netlify-cli\"].version")"
130130
npx netlify login
131131
- name: Get installed Playwright version
132132
id: playwright-version
@@ -152,7 +152,7 @@ jobs:
152152
uses: actions/upload-artifact@v5
153153
if: always()
154154
with:
155-
name: blob-report-${{matrix.version}}-${{ matrix.shard }}-${{ matrix.os }}
155+
name: blob-report-${{matrix.version}}-${{ matrix.shard }}
156156
path: blob-report
157157
retention-days: 1
158158

@@ -249,14 +249,12 @@ jobs:
249249
smoke:
250250
if: always()
251251
needs: setup
252-
252+
runs-on: ubuntu-latest
253253
strategy:
254254
fail-fast: false
255255
matrix:
256256
os: ${{ fromJson(needs.setup.outputs.os) }}
257257
version: ${{ fromJson(needs.setup.outputs.matrix) }}
258-
259-
runs-on: ${{ matrix.os }}
260258
steps:
261259
- uses: actions/checkout@v6
262260
- name: Resolve Next.js version
@@ -300,7 +298,7 @@ jobs:
300298
NETLIFY_AUTH_TOKEN: ${{ secrets.NETLIFY_AUTH_TOKEN }}
301299
run: |
302300
# Control netlify-cli as a regular dev dep but expose it globally for test fixtures to use
303-
npm install -g "netlify-cli@$(npm list --json --depth=0 netlify-cli | jq -r '.dependencies["netlify-cli"].version')"
301+
npm install -g "netlify-cli@$(npm list --json --depth=0 netlify-cli | jq -r ".dependencies[\"netlify-cli\"].version")"
304302
npx netlify login
305303
- name: "Smoke tests"
306304
run: npm run test:ci:smoke
@@ -316,8 +314,6 @@ jobs:
316314
strategy:
317315
fail-fast: false
318316
matrix:
319-
# we do have per OS runs, but we don't need to run on windows to merge reports
320-
os: ${{ fromJson(needs.setup.outputs.os) }}
321317
version: ${{ fromJson(needs.setup.outputs.matrix) }}
322318

323319
runs-on: ubuntu-latest
@@ -344,6 +340,6 @@ jobs:
344340
- name: Upload HTML report
345341
uses: actions/upload-artifact@v5
346342
with:
347-
name: html-report-${{ matrix.version }}-attempt-${{ github.run_attempt }}-${{ matrix.os }}
343+
name: html-report-${{ matrix.version }}-attempt-${{ github.run_attempt }}
348344
path: playwright-report
349345
retention-days: 14

0 commit comments

Comments
 (0)