fix: cookies set in middleware accessible during the same request #2847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrstork
changed the title
Contributor
📊 Package size report 0.09%↑
Unchanged files
🤖 This report was automatically generated by pkg-size-action |
mrstork
force-pushed
the
middleware-cookies
branch
4 times, most recently
from
f73ce83 to
ab19472
Compare
mrstork
force-pushed
the
middleware-cookies
branch
from
ab19472 to
c8379d6
Compare
mrstork
force-pushed
the
middleware-cookies
branch
from
93c8766 to
45fb6dd
Compare
mrstork
force-pushed
the
middleware-cookies
branch
from
45fb6dd to
bc25218
Compare
pieh
requested changes
Apr 17, 2025
pieh
reviewed
Apr 17, 2025
edge-runtime/lib/response.ts
Outdated
| edgeResponse.headers.set('x-middleware-rewrite', relativeUrl) | ||
| request.headers.set('x-middleware-rewrite', target) | ||
| return addMiddlewareHeaders(context.rewrite(target), res) | ||
| return addMiddlewareHeaders(context.rewrite(target), edgeResponse) |
Contributor
There was a problem hiding this comment.
I'm not sure, but possibly here we would also need to handle middleware cookies as well? next.js test fixture doesn't seem to have case for setting cookies for rewrites, so maybe we should not touch it in this PR - just flagging it (so this comment act as potential paper trail in case there was some future report about cookies not being handled for rewrites)
Contributor
Author
There was a problem hiding this comment.
Recreated the bug quite easily with the following middleware, so decided to fix in this PR as well
const nextRes = NextResponse.rewrite(url)
nextRes.cookies.set("nextjs-cookie", "rewrite");
return nextRes;
pieh
approved these changes
Apr 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These changes make it possible to set a cookie in middleware and have that value be accessible at render time during the same request. This should also address a couple e2e tests failures we see in the report.
Part of FRB-1387
Fixes FRB-1748
Fixes #2669
Tests
Used variants of the following setup: