fix: App version and review related issues #1066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 28, 2019
Closed
Closed
whDongRui
changed the title
sunnywx
changed the title
added 8 commits
March 28, 2019 19:58
* fix: ISV review add deploy button * fix: SSH key attch key error * fix: Clusters page reset defalut status
whDongRui
force-pushed
the
fix/github-issues
branch
from
13d723b to
aab07b1
Compare
sunnywx
reviewed
Mar 28, 2019
| @@ -47,7 +47,7 @@ export const checkConfig = { | |||
| version: { | |||
| name: { | |||
| required_info: 'Version No should not be empty"', | |||
| regex: /^\d+((\.|\d)*)+(\d$)/, | |||
| regex: /^\d+((\.|\d|^\s+|\s|\[)*)+((\d|\])$)/, | |||
sunnywx
approved these changes
Mar 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: Version NO check support default value
fix: ISV review add deploy button
fix: SSH key attch key error
fix: Clusters page reset defalut status
fix: Reviews page pagination query error
fix: Local menu apps refresh with api response data
fix: Nav menu logo skip link to self portal
fix: Version sumbit review refresh latest record
fix: Sandbox instancespage add agent tab
fix: Remove reveiw detail page standard link