Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Deploy app click submit button throw error when config file is empty #324

Merged
merged 1 commit into from
Sep 5, 2018
Merged

fix: Deploy app click submit button throw error when config file is empty #324

merged 1 commit into from
Sep 5, 2018

Conversation

whDongRui
Copy link
Contributor

@whDongRui whDongRui commented Sep 5, 2018 •
edited by sunnywx
Loading

solve (#321)

@whDongRui whDongRui requested a review from sunnywx September 5, 2018 10:12
@codecov
Copy link

codecov bot commented Sep 5, 2018

Codecov Report

Merging #324 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #324   +/-   ##
=======================================
  Coverage   19.55%   19.55%           
=======================================
  Files          84       84           
  Lines        1227     1227           
  Branches      237      237           
=======================================
  Hits          240      240           
  Misses        948      948           
  Partials       39       39

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9f3ec1...e28a180. Read the comment docs.

@sunnywx sunnywx changed the title fix: Click button error(not config file) fix: Deploy app click submit button throw error when config file is empty Sep 5, 2018
@sunnywx sunnywx merged commit 55629dd into openpitrix:master Sep 5, 2018
@whDongRui whDongRui deleted the fix/deploy/button branch September 7, 2018 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunnywx sunnywx sunnywx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@whDongRui @sunnywx