Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Icon svg sprite symbols override global vars #392

Merged

Conversation

sunnywx
Copy link
Contributor

@sunnywx sunnywx commented Sep 25, 2018

No description provided.

@codecov
Copy link

codecov bot commented Sep 25, 2018

Codecov Report

Merging #392 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #392   +/-   ##
=======================================
  Coverage   18.21%   18.21%           
=======================================
  Files          86       86           
  Lines        1334     1334           
  Branches      267      267           
=======================================
  Hits          243      243           
  Misses       1044     1044           
  Partials       47       47
Impacted Files Coverage Δ
src/utils/icons.js 100% <ø> (ø) ⬆️
src/components/Base/Icon/index.jsx 89.65% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa7bfab...a3c49f0. Read the comment docs.

@sunnywx sunnywx merged commit 9e28b58 into openpitrix:master Sep 25, 2018
@sunnywx sunnywx deleted the fix/icon-svg-symbol-override-global-vars branch September 25, 2018 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant