Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: No data when change pods of helm cluster #472

Merged
merged 1 commit into from
Oct 10, 2018

Conversation

liiil825
Copy link
Contributor

@liiil825 liiil825 commented Oct 9, 2018

No description provided.

@liiil825 liiil825 requested review from sunnywx and whDongRui October 9, 2018 08:01
@codecov
Copy link

codecov bot commented Oct 9, 2018

Codecov Report

Merging #472 into master will decrease coverage by 0.22%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #472      +/-   ##
==========================================
- Coverage   17.77%   17.54%   -0.23%     
==========================================
  Files          90       92       +2     
  Lines        1384     1402      +18     
  Branches      287      290       +3     
==========================================
  Hits          246      246              
- Misses       1083     1101      +18     
  Partials       55       55
Impacted Files Coverage Δ
src/components/Breadcrumb/index.jsx 0% <0%> (ø)
src/components/Layout/NavLink/index.jsx 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb860fb...e39f2b6. Read the comment docs.

Copy link
Contributor

@sunnywx sunnywx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

基于最新的master来改这个,你checkout的分支落后master了,master改动比较大

@sunnywx sunnywx changed the title fix: No data when change cluster type fix: No data when change pods of helm cluster Oct 9, 2018
@liiil825 liiil825 force-pushed the hotfix/cluster-detail-data branch from f263a1d to e39f2b6 Compare October 10, 2018 03:51
@liiil825
Copy link
Contributor Author

@iwisunny 再看看

@sunnywx sunnywx merged commit 7e782cd into master Oct 10, 2018
@sunnywx sunnywx deleted the hotfix/cluster-detail-data branch October 10, 2018 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants