-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add cluster attach or detach key pairs #474
Conversation
* fix: Home detail header show bug * fix Purchased page apps query bug
Codecov Report
@@ Coverage Diff @@
## master #474 +/- ##
==========================================
- Coverage 17.77% 17.69% -0.08%
==========================================
Files 90 90
Lines 1384 1390 +6
Branches 287 289 +2
==========================================
Hits 246 246
- Misses 1083 1089 +6
Partials 55 55
Continue to review full report at Codecov.
|
src/components/Header/index.jsx
Outdated
becomeDeveloper = () => { | ||
setCookie('role', '', -1); | ||
becomeDeveloper = isNormal => { | ||
if (isNormal) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can use user provider
's method
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The method for add cookie to role when changed normal view, or remove cookie when back developer view.
src/providers/user.js
Outdated
if (this.changedRole === ROLE_NORMAL) { | ||
this.canChangeRole(); | ||
} | ||
} catch (err) {} | ||
|
||
this.accessToken = getCookie('access_token'); | ||
} | ||
|
||
canChangeRole() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this method should return boolean
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method for change the judgment of role,rename changeJudgeRole()
@@ -72,11 +72,11 @@ export default class Layout extends React.Component { | |||
backBtn, | |||
hasSearch, | |||
title, | |||
noLogin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this flag will be removed, no need to use
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok. This is rename isHome.
fix: Home detail header show bug
fix: Purchased page apps query bug