Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add cluster attach or detach key pairs #474

Merged
merged 4 commits into from
Oct 11, 2018

Conversation

whDongRui
Copy link
Contributor

@whDongRui whDongRui commented Oct 10, 2018

  • fix: Home detail header show bug

  • fix: Purchased page apps query bug

* fix: Home detail header show bug

* fix Purchased page apps query bug
@whDongRui whDongRui requested a review from sunnywx October 10, 2018 12:40
@codecov
Copy link

codecov bot commented Oct 10, 2018

Codecov Report

Merging #474 into master will decrease coverage by 0.07%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #474      +/-   ##
==========================================
- Coverage   17.77%   17.69%   -0.08%     
==========================================
  Files          90       90              
  Lines        1384     1390       +6     
  Branches      287      289       +2     
==========================================
  Hits          246      246              
- Misses       1083     1089       +6     
  Partials       55       55
Impacted Files Coverage Δ
src/components/Base/Table/table.jsx 65.03% <ø> (ø) ⬆️
src/components/Header/index.jsx 0% <0%> (ø) ⬆️
src/components/Layout/SideNav/index.jsx 0% <0%> (ø) ⬆️
src/components/Layout/index.jsx 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e782cd...4eb969a. Read the comment docs.

becomeDeveloper = () => {
setCookie('role', '', -1);
becomeDeveloper = isNormal => {
if (isNormal) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can use user provider's method

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The method for add cookie to role when changed normal view, or remove cookie when back developer view.

if (this.changedRole === ROLE_NORMAL) {
this.canChangeRole();
}
} catch (err) {}

this.accessToken = getCookie('access_token');
}

canChangeRole() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this method should return boolean

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This method for change the judgment of role,rename changeJudgeRole()

@@ -72,11 +72,11 @@ export default class Layout extends React.Component {
backBtn,
hasSearch,
title,
noLogin
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this flag will be removed, no need to use

Copy link
Contributor Author

@whDongRui whDongRui Oct 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok. This is rename isHome.

@whDongRui whDongRui merged commit b5a6301 into openpitrix:master Oct 11, 2018
@whDongRui whDongRui deleted the attach/keypairs branch October 11, 2018 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants