fix: Add repo secret key validate #514
Conversation
fix: Create user remove default role fix: The vxnet list is incomplete
Codecov Report
@@ Coverage Diff @@
## master #514 +/- ##
======================================
Coverage 17.5% 17.5%
======================================
Files 91 91
Lines 1405 1405
Branches 294 294
======================================
Hits 246 246
Misses 1103 1103
Partials 56 56Continue to review full report at Codecov.
|
src/config/translation.js
Outdated
| @@ -50,6 +50,9 @@ const tsObj = { | |||
| 'Runtime Selector missing value': '环境选择器缺失值', | |||
| 'Invalid s3 url, should be like s3://s3.pek3a.qingstor.com/op-repo': | |||
| '无效的s3网址，应该是这样: s3://s3.pek3a.qingstor.com/op-repo', | |||
| 'Verify that the information requested is incomplete!': '验证要求输入的信息不完整！', | |||
There was a problem hiding this comment.
Information to be verified is incomplete
src/locales/zh/translation.json
Outdated
| @@ -211,6 +211,7 @@ | |||
| "Search Repo": "搜索仓库", | |||
| "Trigger indexer": "触发索引器", | |||
| "Runtime Selectors": "环境选择器", | |||
| "URL": "网址", | |||
There was a problem hiding this comment.
URL, i think no need to translate.
| @@ -236,7 +236,7 @@ export default class Users extends Component { | |||
| selectName | |||
| } = userStore; | |||
|
|
|||
| const data = userStore.users.toJSON(); | |||
| const data = toJS(userStore.users); | |||
There was a problem hiding this comment.
toJS is deprecated in mobx, recommend to use toJSON
There was a problem hiding this comment.
If use toJSON, modify user name will also change table list data. Becase observable lead to data bidirectional binding.
| @@ -203,7 +203,10 @@ ${this.yamlStr}`; | |||
|
|
|||
| @action | |||
| async fetchSubnets(runtimeId) { | |||
| const result = await this.request.get(`clusters/subnets`, { runtime_id: runtimeId }); | |||
| const result = await this.request.get(`clusters/subnets`, { | |||
| runtime_id: runtimeId, | |||
There was a problem hiding this comment.
There is add parameter limit, for fix query result more 10 datas.
fix: Create user remove default role
fix: The vxnet list is incomplete