Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Cluster detail loading when runtime type not resolved #546

Merged
merged 1 commit into from
Nov 20, 2018

Conversation

sunnywx
Copy link
Contributor

@sunnywx sunnywx commented Nov 20, 2018

Webpack dev build add notifier
Add LazyLoad component

Webpack dev build add notifier
Add LazyLoad component
@codecov
Copy link

codecov bot commented Nov 20, 2018

Codecov Report

Merging #546 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #546      +/-   ##
==========================================
+ Coverage   16.24%   16.25%   +0.01%     
==========================================
  Files          94       95       +1     
  Lines        1551     1550       -1     
  Branches      333      332       -1     
==========================================
  Hits          252      252              
+ Misses       1243     1242       -1     
  Partials       56       56
Impacted Files Coverage Δ
src/components/Loading/index.jsx 75% <ø> (+8.33%) ⬆️
src/components/LazyLoad/index.jsx 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bceb49...dd59d97. Read the comment docs.

@liiil825
Copy link
Contributor

review ok

@sunnywx sunnywx merged commit 8e535e7 into openpitrix:master Nov 20, 2018
@sunnywx sunnywx deleted the fix/cluster-detail-loading branch November 20, 2018 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants