Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove window.onscroll in Layout component #549

Merged

Conversation

sunnywx
Copy link
Contributor

@sunnywx sunnywx commented Nov 26, 2018

No description provided.

@sunnywx sunnywx requested a review from whDongRui November 26, 2018 04:13
@sunnywx sunnywx changed the title fix: Remove window.scroll in Layout component fix: Remove window.onscroll in Layout component Nov 26, 2018
@sunnywx sunnywx requested a review from liiil825 November 26, 2018 04:13
@codecov
Copy link

codecov bot commented Nov 26, 2018

Codecov Report

Merging #549 into master will increase coverage by 0.1%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #549     +/-   ##
=========================================
+ Coverage   16.23%   16.33%   +0.1%     
=========================================
  Files          95       95             
  Lines        1540     1530     -10     
  Branches      329      328      -1     
=========================================
  Hits          250      250             
+ Misses       1235     1225     -10     
  Partials       55       55
Impacted Files Coverage Δ
src/components/Layout/SideNav/index.jsx 0% <ø> (ø) ⬆️
src/components/Layout/index.jsx 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb050c5...5e237b4. Read the comment docs.

@sunnywx sunnywx merged commit 30ea9cd into openpitrix:master Nov 26, 2018
@sunnywx sunnywx deleted the fix/remove-scroll-event-in-layout-comp branch November 26, 2018 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants