feat: Add version audit record #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #567 +/- ##
==========================================
- Coverage 16.23% 16.22% -0.02%
==========================================
Files 98 98
Lines 1595 1596 +1
Branches 341 342 +1
==========================================
Hits 259 259
- Misses 1281 1282 +1
Partials 55 55
Continue to review full report at Codecov.
|
whDongRui
force-pushed
the
new/app/audits
branch
from
4ac2caf to
8e7de15
Compare
liiil825
approved these changes
Dec 6, 2018
sunnywx
reviewed
Dec 6, 2018
| const { appId } = match.params; | ||
|
|
||
| await appVersionStore.fetchAll({ app_id: appId }); | ||
| const versions = appVersionStore.versions; |
There was a problem hiding this comment.
const {versions} = appVersionStore
sunnywx
reviewed
Dec 6, 2018
| } | ||
| } | ||
|
|
||
| expandReason(audit) { |
There was a problem hiding this comment.
rename the method to toggleReason is better
sunnywx
approved these changes
Dec 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.