Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Validate runtime credential and create helm type runtime #601

Conversation

sunnywx
Copy link
Contributor

@sunnywx sunnywx commented Dec 20, 2018

No description provided.

@codecov
Copy link

codecov bot commented Dec 20, 2018

Codecov Report

Merging #601 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #601   +/-   ##
======================================
  Coverage    14.6%   14.6%           
======================================
  Files         104     104           
  Lines        1739    1739           
  Branches      385     385           
======================================
  Hits          254     254           
  Misses       1426    1426           
  Partials       59      59

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa5f664...477b0e5. Read the comment docs.

@sunnywx sunnywx changed the title fix: Validate runtime credential method as post fix: Validate runtime credential Dec 20, 2018
Add helm type runtime creation
@sunnywx sunnywx requested a review from whDongRui December 20, 2018 10:58
@sunnywx sunnywx changed the title fix: Validate runtime credential fix: Validate runtime credential and create helm type runtime Dec 20, 2018
@sunnywx sunnywx requested a review from liiil825 December 20, 2018 12:28
@sunnywx sunnywx merged commit eeb80e2 into openpitrix:master Dec 21, 2018
@sunnywx sunnywx deleted the fix/validate-runtime-credential-request-method branch December 21, 2018 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants