feat: App mgmt for isv and admin #617
Conversation
Codecov Report
@@ Coverage Diff @@
## master #617 +/- ##
=========================================
- Coverage 14.42% 14.22% -0.2%
=========================================
Files 104 106 +2
Lines 1747 1771 +24
Branches 385 388 +3
=========================================
Hits 252 252
- Misses 1438 1462 +24
Partials 57 57
Continue to review full report at Codecov.
|
| @@ -33,6 +33,10 @@ export default class Image extends React.Component { | |||
| } | |||
|
|
|||
| shouldComponentUpdate(nextProps, nextState) { | |||
| if (nextProps.src !== this.props.src) { | |||
There was a problem hiding this comment.
don't setState in shouldCompnentUpdate
There was a problem hiding this comment.
If src value initialize to "", this.state.failed will true. The nex props src has value, but 'failed' still is true, this is a bug.
| @@ -171,6 +171,8 @@ | |||
| transition: all $transition-speed; | |||
| word-wrap: break-word; | |||
| word-break: break-all; | |||
| font-size: 12px; | |||
There was a problem hiding this comment.
General font not used variable，only color used variable
| @@ -0,0 +1,699 @@ | |||
| import React, { Component, Fragment } from 'react'; | |||
There was a problem hiding this comment.
If this file not used, can remove it
There was a problem hiding this comment.
ok，maybe other undeveloped pages refer to this page.
whDongRui
force-pushed
the
new/app-detail
branch
from
6ad8742 to
6c91f58
Compare
solve #599 -- App mgmt