Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Download app version package file from browser #652

Merged

Conversation

sunnywx
Copy link
Contributor

@sunnywx sunnywx commented Jan 9, 2019

No description provided.

@sunnywx sunnywx requested a review from whDongRui January 9, 2019 04:23
@sunnywx sunnywx force-pushed the feat/download-package-tgz-in-browser branch from 73d868e to f96cf8f Compare January 9, 2019 04:25
@sunnywx
Copy link
Contributor Author

sunnywx commented Jan 9, 2019

solve #648

@codecov
Copy link

codecov bot commented Jan 9, 2019

Codecov Report

Merging #652 into master will decrease coverage by <.01%.
The diff coverage is 12.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #652      +/-   ##
==========================================
- Coverage   13.95%   13.95%   -0.01%     
==========================================
  Files         112      112              
  Lines        1841     1849       +8     
  Branches      400      401       +1     
==========================================
+ Hits          257      258       +1     
- Misses       1516     1523       +7     
  Partials       68       68
Impacted Files Coverage Δ
src/utils/index.js 5.26% <12.5%> (+0.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cad0922...f96cf8f. Read the comment docs.

@liiil825
Copy link
Contributor

liiil825 commented Jan 9, 2019

我觉得没必要在前端做,可以放在 node 后端里,转移为二进制格式,Content-Type 和 Content-Disposition

@sunnywx
Copy link
Contributor Author

sunnywx commented Jan 9, 2019

我觉得没必要在前端做,可以放在 node 后端里,转移为二进制格式,Content-Type 和 Content-Disposition

嗯,你可以试下

@sunnywx sunnywx merged commit 6621cb3 into openpitrix:master Jan 9, 2019
@sunnywx sunnywx deleted the feat/download-package-tgz-in-browser branch January 9, 2019 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants