fix: User or sandbox instance detail page link #734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Codecov Report
@@ Coverage Diff @@
## master #734 +/- ##
=======================================
Coverage 32.33% 32.33%
=======================================
Files 102 102
Lines 1367 1367
Branches 352 352
=======================================
Hits 442 442
Misses 894 894
Partials 31 31Continue to review full report at Codecov.
|
whDongRui
reviewed
Jan 25, 2019
| clusterId | ||
| }); | ||
| }; | ||
|
|
There was a problem hiding this comment.
感觉这里不用写这个判断方法，直接获取当前的路由， const { pathname } = history.location;，再把clusterId拼在结尾就行了{${pathname}/${clusterId}}
There was a problem hiding this comment.
这样写清晰些，链接分别对应三个不同的路由
liiil825
approved these changes
Jan 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.