-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adiciona páginas de información #116
base: staging
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Una pregunta y una sugerencia para agregarle el estado :hover a los links @LuighiV, gracias!
{LinkItems.map(({ name, href }) => { | ||
return ( | ||
<Styled.Item isMobile={isMobile} key={name}> | ||
<LinkWithFallback to={href} target="_self"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No sé si debamos usar LinkWithFallback
aquí dado que sabemos que todos son links válidos.
O si vamos a usar LinkWithFallback
como una regla general, debería de tener un estado :hover
cuando el usuario pasa el cursor por encima.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dale, si es que en un inicio lo estaba probando, lo puedo cambiar. Lo del hover
no estaba definido creo. Pero le puedo agregar tal como está en otros enlaces con un underline.
closes #113
closes #114