Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adiciona páginas de información #116

Open
wants to merge 4 commits into
base: staging
Choose a base branch
from
Open

Adiciona páginas de información #116

wants to merge 4 commits into from

Conversation

LuighiV
Copy link
Contributor

@LuighiV LuighiV commented Aug 4, 2022

  • Adiciona la barra de menú (desktop) y el botón (mobile)
  • Adiciona la página de reportes
  • Adiciona la página de about us

closes #113
closes #114

@LuighiV LuighiV requested a review from wixo August 4, 2022 22:15
@vercel
Copy link

vercel bot commented Aug 4, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
proclama-ciudadana ✅ Ready (Inspect) Visit Preview Aug 4, 2022 at 10:15PM (UTC)

Copy link
Contributor

@wixo wixo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Una pregunta y una sugerencia para agregarle el estado :hover a los links @LuighiV, gracias!

{LinkItems.map(({ name, href }) => {
return (
<Styled.Item isMobile={isMobile} key={name}>
<LinkWithFallback to={href} target="_self">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No sé si debamos usar LinkWithFallback aquí dado que sabemos que todos son links válidos.
O si vamos a usar LinkWithFallback como una regla general, debería de tener un estado :hover cuando el usuario pasa el cursor por encima.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dale, si es que en un inicio lo estaba probando, lo puedo cambiar. Lo del hover no estaba definido creo. Pero le puedo agregar tal como está en otros enlaces con un underline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crear seccion "Quienes somos" Crear seccion de "nuestros reportes"
2 participants