Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fmt/899 and fmt/900 contain byte sequences we can't convert #103

Open
mistydemeo opened this issue Mar 12, 2017 · 6 comments
Open

fmt/899 and fmt/900 contain byte sequences we can't convert #103

mistydemeo opened this issue Mar 12, 2017 · 6 comments
Assignees
Labels
bug A product defect that needs fixing P1 High priority issues to be scheduled in the upcoming release
Milestone

Comments

@mistydemeo
Copy link
Contributor

mistydemeo commented Mar 12, 2017

Dev Effort

TBCD

Description

fmt/899 (Windows Portable Executable 32-bit) and fmt/900 (Windows Portable Executable 64-bit) contain regexes that trip the __INCOMPATIBLE_SIG__ case in prepare.convert_to_regex. Their byte sequences look like this:

<!-- fmt/899 -->
<ByteSequenceValue>4D5A{126-128500}50450000{20}0B01{66}[0000:1000]</ByteSequenceValue>

<!-- fmt/900 -->
<ByteSequenceValue>4D5A{126-128500}50450000{20}0B02{66}[0000:1000]</ByteSequenceValue>

Specifically, the [0000:1000] sequence trips up convert_to_regex here, where it assumes that the digits following the open square bracket are at most one byte. There's a similar assumption with the portion after the colon.

@jrwdunham
Copy link
Contributor

I have recently run into this issue also. The ultimate problem here seems to be lack of clarity over what exactly is the specification of the regular expression language used to write these ByteSequenceValues.

@ghost ghost added bug A product defect that needs fixing P1 High priority issues to be scheduled in the upcoming release labels Mar 13, 2019
@ghost ghost added this to the v1.4.0-m4 milestone Mar 13, 2019
@ablwr
Copy link
Contributor

ablwr commented Oct 8, 2019

hmmmm, anyone know where I can grab some test files?

@ross-spencer
Copy link

@ablwr
Copy link
Contributor

ablwr commented Oct 8, 2019

Thanks! I gave up when I got an error previously, but you've convinced me to go back and wrangle it up with ye olde Python2.

@carlwilson carlwilson removed this from the v1.4.0-m4 milestone May 5, 2020
@carlwilson carlwilson assigned carlwilson and unassigned ablwr May 5, 2020
@carlwilson carlwilson added this to the v1.6 milestone May 5, 2020
@carlwilson carlwilson modified the milestones: v1.6, OPF Hackathon 2023 Tasks Jun 19, 2023
@carlwilson
Copy link
Member

Hackathon 2023 Review: Selected for initial task list. @sromkey one of the maintainer team might want to take this one?

@carlwilson carlwilson removed their assignment Jul 17, 2023
@Dhwaniartefact
Copy link

@carlwilson : I am investigating this issue.

@Dhwaniartefact Dhwaniartefact self-assigned this Jul 20, 2023
@carlwilson carlwilson modified the milestones: OPF Hackathon 2023 Tasks, v1.8 Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A product defect that needs fixing P1 High priority issues to be scheduled in the upcoming release
Projects
None yet
Development

No branches or pull requests

6 participants