Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Officially remove OmegaPRM-v1 #56

Open
gzqaq opened this issue Nov 13, 2024 · 2 comments
Open

Officially remove OmegaPRM-v1 #56

gzqaq opened this issue Nov 13, 2024 · 2 comments

Comments

@gzqaq
Copy link
Collaborator

gzqaq commented Nov 13, 2024

When dealing with the new Math-APS dataset generated by data/omegaPRM_v2 #52, I notice that the flat format (explained here) is only slightly different from the old Math-APS, so there will be quite redundant code if I need to support both. Since the old version does have some problems #23, is it ok to remove the old OmegaPRM so that I can maintain a more compact preprocess?

@iamlilAJ
@gzqaq
Copy link
Collaborator Author

gzqaq commented Nov 13, 2024

Also I suggest that @iamlilAJ explains the two different formats (flat and tree) in the README of data/omegaPRM_v2.

@iamlilAJ
Copy link
Collaborator

The README is updated now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gzqaq @iamlilAJ