Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note editor - discard invalid value in note #1733

Open
xkopenreview opened this issue Nov 22, 2023 · 0 comments
Open

Note editor - discard invalid value in note #1733

xkopenreview opened this issue Nov 22, 2023 · 0 comments

Comments

@xkopenreview
Copy link
Collaborator

when invitation is modified after some notes were posted, the value in those notes may become invalid. for example invitation field type is changed from string to string[] but the value in note is still string
currently this may cause the note editor logic to break

discussed this with Carlos:

  1. user who edited this change should be notified that the change could make value in some notes invalid
  2. note editor should discard value in note when there's a type mismatch or value mismatch (for example the note value is not in options defined in invitation) but still show it for user to reference (because user need to input new value)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant