-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edge browser: support items to get the signatures of an edge #1749
Comments
should it also support enum array enum object? or it will always use items |
AFAIK we should always use items for signatures, right? |
i think converting some groups to items can potentially get 10x more groups than required.
it can only get groups using the prefix
and filter in edge browser for those ends with Area_Chair_.* which returns about ten time more groups compares to regex pipe |
I think the API call to get the signature groups should be done at the moment of editing the edge. |
Can the regex to be like?:
I think the UI can replace the dollar sign and get the group by prefix. |
Use this PR to test it: openreview/openreview-py#1965 |
Currently the edge browser only support API 1 invitation schema.
I suggest to change the logic so the UI can load the signatures from the
items
keyword and we don't need to use a regex with pipes.I can provide a test in openreview-py
The text was updated successfully, but these errors were encountered: