Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edge browser: support items to get the signatures of an edge #1749

Open
melisabok opened this issue Dec 7, 2023 · 6 comments
Open

Edge browser: support items to get the signatures of an edge #1749

melisabok opened this issue Dec 7, 2023 · 6 comments
Assignees

Comments

@melisabok
Copy link
Member

Currently the edge browser only support API 1 invitation schema.

I suggest to change the logic so the UI can load the signatures from the items keyword and we don't need to use a regex with pipes.

I can provide a test in openreview-py

@xkopenreview
Copy link
Collaborator

should it also support enum array enum object? or it will always use items

@melisabok
Copy link
Member Author

AFAIK we should always use items for signatures, right?

@xkopenreview
Copy link
Collaborator

i think converting some groups to items can potentially get 10x more groups than required.
for example to get groups for

NeurIPS.cc/2023/Conference/Submission.*/Area_Chair_.*

it can only get groups using the prefix

NeurIPS.cc/2023/Conference/Submission.*

and filter in edge browser for those ends with Area_Chair_.*

which returns about ten time more groups compares to regex pipe

@melisabok
Copy link
Member Author

I think the API call to get the signature groups should be done at the moment of editing the edge.

@melisabok
Copy link
Member Author

melisabok commented Dec 20, 2023

Can the regex to be like?:

NeurIPS.cc/2023/Conference/Submission${6/head/number}/Area_Chair_.*

I think the UI can replace the dollar sign and get the group by prefix.

@melisabok
Copy link
Member Author

Use this PR to test it: openreview/openreview-py#1965

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants