Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jakarta.xml.ws-api is adding wrong dependency version #185

Closed
thigg opened this issue Feb 28, 2023 · 2 comments
Closed

jakarta.xml.ws-api is adding wrong dependency version #185

thigg opened this issue Feb 28, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@thigg
Copy link

thigg commented Feb 28, 2023

I ran the migrate jdk11 receipe on a project that already uses jakarta.xml.ws-api:2.3.3.

The receipe upgraded the version to 2.3.6. This version exists for the runtime only.

There is no version 2.3.6 of the api.

This would be correct: (and how it was before running the receipe)

  <dependency>
                <groupId>jakarta.xml.ws</groupId>
                <artifactId>jakarta.xml.ws-api</artifactId>
                <version>2.3.3</version>
            </dependency>
            <dependency>
                <groupId>com.sun.xml.ws</groupId>
                <artifactId>jaxws-rt</artifactId>
                <version>2.3.6</version>
                <scope>runtime</scope>
            </dependency>

This was the change the receipe introduced:

            <dependency>
                <groupId>jakarta.xml.ws</groupId>
                <artifactId>jakarta.xml.ws-api</artifactId>
                <version>2.3.6</version>
            </dependency>
            <dependency>
                <groupId>com.sun.xml.ws</groupId>
                <artifactId>jaxws-rt</artifactId>
                <version>2.3.6</version>
                <scope>runtime</scope>
            </dependency>

Ran the receipe with:

mvn -U org.openrewrite.maven:rewrite-maven-plugin:run \             
-Drewrite.recipeArtifactCoordinates=org.openrewrite.recipe:rewrite-migrate-java:LATEST \
-DactiveRecipes=org.openrewrite.java.migrate.Java8toJava11
@timtebeek timtebeek added the bug Something isn't working label Feb 28, 2023
@timtebeek timtebeek transferred this issue from openrewrite/rewrite Mar 1, 2023
@timtebeek
Copy link
Contributor

Thanks for reporting this issue here @thigg ! Would you happen to have a snippet of the log output that highlights which recipes made changes to your pom.xml file? Those lines typically start with [WARNING] Changes have been made to pom.xml by:

At first glance I would only expect changes to be made by JavaxXmlWsMigrationToJakartaXmlWs, which ought to pick up the latest.release version as seen on Maven Central.

@timtebeek
Copy link
Contributor

There have been a lot of changes since this issue was opened; especially today with these going through

I'd lean towards closing this one and reopening a new one if necessary.

@github-project-automation github-project-automation bot moved this from Backlog to Done in OpenRewrite Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

2 participants