UseTextBlocks - incorrect escaping for Kotlin

[nmck257]

What version of OpenRewrite are you using?

rewrite-recipe-bom 2.5.1

How are you running OpenRewrite?

maven plugin 5.14.1

What is the smallest, simplest way to reproduce the problem?

const val s = "[{\n" +
        "    \"errorSource\"      : \"source\",\n" +
        "    \"errorCode\"        : \"code\",\n" +
        "    \"errorDescription\" : \"error\"\n" +
        "}]"

What did you expect to see?

const val s = """
[{
    "errorSource"      : "source",
    "errorCode"        : "code",
    "errorDescription" : "error"
}]
"""

What did you see instead?

const val s = """
[{\\n\
    \\"errorSource\\"      : \\"source\\",\\n\
    \\"errorCode\\"        : \\"code\\",\\n\
    \\"errorDescription\\" : \\"error\\"\\n\
}]\
"""

(note that this was on Windows, in case that's relevant to some of those escapes near the line endings)

Are you interested in contributing a fix to OpenRewrite?

Sorta? Mostly I'm curious:

• is it premature for us to start "fixing" (optimizing?) existing Java visitors to also make good choices for Kotlin?
• do we have any established patterns / samples for how a visitor should take different codepaths based on whether it's visiting Java/Kotlin/something else?

[knutwannheden]

/cc @traceyyoshima