-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include adding javafx dependencies with JDK17 upgrade recipe #472
Comments
Thanks for logging an issue! As discussed on Slack there's likely a couple changes we'd need to make for JavaFX projects adopting Java 17; would you mind breaking down those changes a bit in this issue? Things like adding a dependency, changing packages or classes, or switching to a different runtime. That way we're better able to start codifying such changes as recipes. |
Thanks for your prompt reply Tim. These are the following changes which I observed which needs to be incorporated to used javafx with Java 17:
|
I think adding the required dependencies is the most straightforward way we can keep supporting JavaFX if that's used. If folks only use one or two classes (such as Pair here), then it might make sense to use |
Yeah correct Tim. I resolved the issue by adding the following dependencies in the parent pom:
And it worked. |
Looks like those could be added with a declarative recipe if needed. That would then close out this issue for folks similarly migrating. Is that something you'd want to contribute? |
What problem are you trying to solve?
I am running the JDK17 update recipe. But once the recipe is run and I am trying to test it out I am getting the following error:
Describe the solution you'd like
The solution should be incorporated in the JDK17 upgrade recipe only so that the solution automatically gets remdified.
Have you considered any alternatives or workarounds?
Tried using
java.util.Map.Entry
but also some in that sense i needed to change the user codeThe text was updated successfully, but these errors were encountered: